From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Refactor the `rzg3s_cpg_div_clk_register` function to eliminate the
unnecessary `base` parameter and streamline parameter usage. The `base`
pointer was unused, and the `clks` pointer can be accessed directly from
the `priv` structure.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/clk/renesas/rzg2l-cpg.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c
index 91cf972a20c3..129067b090bc 100644
--- a/drivers/clk/renesas/rzg2l-cpg.c
+++ b/drivers/clk/renesas/rzg2l-cpg.c
@@ -339,9 +339,9 @@ static const struct clk_ops rzg3s_div_clk_ops = {
 };
 
 static struct clk * __init
-rzg3s_cpg_div_clk_register(const struct cpg_core_clk *core, struct clk **clks,
-			   void __iomem *base, struct rzg2l_cpg_priv *priv)
+rzg3s_cpg_div_clk_register(const struct cpg_core_clk *core, struct rzg2l_cpg_priv *priv)
 {
+	struct clk **clks = priv->clks;
 	struct div_hw_data *div_hw_data;
 	struct clk_init_data init = {};
 	const struct clk_div_table *clkt;
@@ -1149,7 +1149,7 @@ rzg2l_cpg_register_core_clk(const struct cpg_core_clk *core,
 						 priv->base, priv);
 		break;
 	case CLK_TYPE_G3S_DIV:
-		clk = rzg3s_cpg_div_clk_register(core, priv->clks, priv->base, priv);
+		clk = rzg3s_cpg_div_clk_register(core, priv);
 		break;
 	case CLK_TYPE_MUX:
 		clk = rzg2l_cpg_mux_clk_register(core, priv->base, priv);
-- 
2.34.1

Hi Prabhakar,

On Fri, Jun 28, 2024 at 3:11 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
>
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Refactor the `rzg3s_cpg_div_clk_register` function to eliminate the
> unnecessary `base` parameter and streamline parameter usage. The `base`
> pointer was unused, and the `clks` pointer can be accessed directly from
> the `priv` structure.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/drivers/clk/renesas/rzg2l-cpg.c
> +++ b/drivers/clk/renesas/rzg2l-cpg.c
> @@ -339,9 +339,9 @@ static const struct clk_ops rzg3s_div_clk_ops = {
>  };
>
>  static struct clk * __init
> -rzg3s_cpg_div_clk_register(const struct cpg_core_clk *core, struct clk **clks,
> -                          void __iomem *base, struct rzg2l_cpg_priv *priv)
> +rzg3s_cpg_div_clk_register(const struct cpg_core_clk *core, struct rzg2l_cpg_priv *priv)
>  {
> +       struct clk **clks = priv->clks;

"clks" is used only once in this function, so I'd rather use priv->clks[...]
directly below instead of adding another local variable.

>         struct div_hw_data *div_hw_data;
>         struct clk_init_data init = {};
>         const struct clk_div_table *clkt;

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds