Add bindings for Sony IMX728.
Signed-off-by: Spencer Hill <shill@d3engineering.com>
---
.../devicetree/bindings/media/i2c/sony,imx728.yaml | 119 +++++++++++++++++++++
MAINTAINERS | 7 ++
2 files changed, 126 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
new file mode 100644
index 000000000000..1b14dbcc473a
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
@@ -0,0 +1,119 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx728.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony IMX728 Camera Sensor
+
+maintainers:
+ - Spencer Hill <shill@d3engineering.com>
+
+description:
+ The Sony IMX728 is a 1/1.72-Inch CMOS Solid-state image sensor with a
+ color square pixel array and 8.39M active pixels. It is programmed
+ through an I2C interface.
+
+ The sensor can output up to 3840x2160 at a maximum of 45 frames/s over
+ a CSI-2 serial interface. It supports RAW24/20/16/12 and 10.
+
+properties:
+ compatible:
+ enum:
+ - sony,imx728
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ description: Clock frequency from 18 to 30MHz
+ maxItems: 1
+
+ clock-names:
+ const: inck
+
+ reset-gpios:
+ maxItems: 1
+ description:
+ Specifier for the GPIO connected to the XCLR (System Reset) pin.
+
+ avdd-supply:
+ description: Analog power supply (3.3V)
+
+ dvdd-supply:
+ description: Digital core power supply (1.1V)
+
+ ovdd-supply:
+ description: Digital I/O power supply (1.8V)
+
+ port:
+ $ref: /schemas/graph.yaml#/properties/port
+ additionalProperties: false
+
+ properties:
+ endpoint:
+ $ref: ../video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ data-lanes:
+ oneOf:
+ - items:
+ - const: 1
+ - const: 2
+ - items:
+ - const: 1
+ - const: 2
+ - const: 3
+ - const: 4
+ link-frequencies: true
+
+ required:
+ - data-lanes
+ - link-frequencies
+
+ required:
+ - endpoint
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ clock-frequency = <400000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ camera@1a {
+ compatible = "sony,imx728";
+ reg = <0x1a>;
+
+ clocks = <&fixed_clock>;
+ clock-names = "inck";
+
+ reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
+
+ avdd-supply = <&camera_vdda_3v3>;
+ dvdd-supply = <&camera_vddd_1v1>;
+ ovdd-supply = <&camera_vddo_1v8>;
+
+ port {
+ camera1: endpoint {
+ remote-endpoint = <&csi2_phy0>;
+ data-lanes = <1 2 3 4>;
+ link-frequencies = /bits/ 64 <800000000>;
+ };
+ };
+ };
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index ef6be9d95143..a2811249ac8c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20589,6 +20589,13 @@ T: git git://linuxtv.org/media_tree.git
F: Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
F: drivers/media/i2c/imx415.c
+SONY IMX728 SENSOR DRIVER
+M: Spencer Hill <shill@d3engineering.com>
+L: linux-media@vger.kernel.org
+S: Maintained
+F: Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
+F: drivers/media/i2c/imx728.c
+
SONY MEMORYSTICK SUBSYSTEM
M: Maxim Levitsky <maximlevitsky@gmail.com>
M: Alex Dubov <oakad@yahoo.com>
--
2.43.0
Please be aware that this email includes email addresses outside of the organization.
On Fri, 28 Jun 2024 17:17:00 -0400, Spencer Hill wrote:
> Add bindings for Sony IMX728.
>
> Signed-off-by: Spencer Hill <shill@d3engineering.com>
> ---
> .../devicetree/bindings/media/i2c/sony,imx728.yaml | 119 +++++++++++++++++++++
> MAINTAINERS | 7 ++
> 2 files changed, 126 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml:62:17: [warning] wrong indentation: expected 18 but found 16 (indentation)
./Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml:65:17: [warning] wrong indentation: expected 18 but found 16 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx728.example.dtb: camera@1a: port:endpoint: Unevaluated properties are not allowed ('data-lanes', 'link-frequencies' were unexpected)
from schema $id: http://devicetree.org/schemas/media/i2c/sony,imx728.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240628-imx728-driver-v2-1-80efa6774286@d3engineering.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
On 28/06/2024 23:17, Spencer Hill wrote:
> Add bindings for Sony IMX728.
>
> Signed-off-by: Spencer Hill <shill@d3engineering.com>
> +
> + clocks:
> + description: Clock frequency from 18 to 30MHz
> + maxItems: 1
> +
> + clock-names:
> + const: inck
clock-names do not seem that useful - name is pretty obvious. Drop.
> +
> + reset-gpios:
> + maxItems: 1
> + description:
> + Specifier for the GPIO connected to the XCLR (System Reset) pin.
> +
> + avdd-supply:
> + description: Analog power supply (3.3V)
> +
> + dvdd-supply:
> + description: Digital core power supply (1.1V)
> +
> + ovdd-supply:
> + description: Digital I/O power supply (1.8V)
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: ../video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + oneOf:
> + - items:
> + - const: 1
> + - const: 2
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> + link-frequencies: true
Drop, not needed.
> +
> + required:
> + - data-lanes
> + - link-frequencies
> +
> + required:
> + - endpoint
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + clock-frequency = <400000>;
Drop
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera@1a {
> + compatible = "sony,imx728";
> + reg = <0x1a>;
> +
> + clocks = <&fixed_clock>;
> + clock-names = "inck";
> +
> + reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> +
> + avdd-supply = <&camera_vdda_3v3>;
> + dvdd-supply = <&camera_vddd_1v1>;
> + ovdd-supply = <&camera_vddo_1v8>;
> +
> + port {
> + camera1: endpoint {
> + remote-endpoint = <&csi2_phy0>;
> + data-lanes = <1 2 3 4>;
> + link-frequencies = /bits/ 64 <800000000>;
> + };
> + };
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ef6be9d95143..a2811249ac8c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20589,6 +20589,13 @@ T: git git://linuxtv.org/media_tree.git
> F: Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> F: drivers/media/i2c/imx415.c
>
> +SONY IMX728 SENSOR DRIVER
> +M: Spencer Hill <shill@d3engineering.com>
> +L: linux-media@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
> +F: drivers/media/i2c/imx728.c
There is no such file. Patches must be bisectable.
Best regards,
Krzysztof
On 01/07/2024 11:36, Krzysztof Kozlowski wrote: > On 28/06/2024 23:17, Spencer Hill wrote: >> Add bindings for Sony IMX728. >> >> Signed-off-by: Spencer Hill <shill@d3engineering.com> > > >> + >> + clocks: >> + description: Clock frequency from 18 to 30MHz >> + maxItems: 1 >> + >> + clock-names: >> + const: inck > > clock-names do not seem that useful - name is pretty obvious. Drop. ... and the binding was not tested. You must test them before asking maintainers to review. Otherwise we will just ignore the patches. :( Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.