remoteproc: k3-dsp: Fix log levels where appropriate

[PATCH v2] remoteproc: k3-dsp: Fix log levels where appropriate

Posted by Garrett Giordano 1 year, 5 months ago

Driver was logging information as errors. Changed dev_err to dev_dbg
where appropriate.

Signed-off-by: Garrett Giordano <ggiordano@phytec.com>
---
-v2
  - Change from dev_info to dev_dbg
  - Drop k3-r5 PATCH
---
 drivers/remoteproc/ti_k3_dsp_remoteproc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
index 3555b535b168..a22d41689a7d 100644
--- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
+++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
@@ -327,7 +327,7 @@ static int k3_dsp_rproc_start(struct rproc *rproc)
 		goto put_mbox;
 	}

-	dev_err(dev, "booting DSP core using boot addr = 0x%x\n", boot_addr);
+	dev_dbg(dev, "booting DSP core using boot addr = 0x%x\n", boot_addr);
 	ret = ti_sci_proc_set_config(kproc->tsp, boot_addr, 0, 0);
 	if (ret)
 		goto put_mbox;
--
2.25.1

Re: [PATCH v2] remoteproc: k3-dsp: Fix log levels where appropriate

Posted by Mathieu Poirier 1 year, 5 months ago

On Wed, Jun 26, 2024 at 12:14:38PM -0700, Garrett Giordano wrote:
> Driver was logging information as errors. Changed dev_err to dev_dbg
> where appropriate.
> 
> Signed-off-by: Garrett Giordano <ggiordano@phytec.com>
> ---
> -v2
>   - Change from dev_info to dev_dbg
>   - Drop k3-r5 PATCH
> ---
>  drivers/remoteproc/ti_k3_dsp_remoteproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied.

Thanks,
Mathieu

> diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> index 3555b535b168..a22d41689a7d 100644
> --- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> @@ -327,7 +327,7 @@ static int k3_dsp_rproc_start(struct rproc *rproc)
>  		goto put_mbox;
>  	}
> 
> -	dev_err(dev, "booting DSP core using boot addr = 0x%x\n", boot_addr);
> +	dev_dbg(dev, "booting DSP core using boot addr = 0x%x\n", boot_addr);
>  	ret = ti_sci_proc_set_config(kproc->tsp, boot_addr, 0, 0);
>  	if (ret)
>  		goto put_mbox;
> --
> 2.25.1
>

Re: [PATCH v2] remoteproc: k3-dsp: Fix log levels where appropriate

Posted by Andrew Davis 1 year, 5 months ago

On 6/26/24 2:14 PM, Garrett Giordano wrote:
> Driver was logging information as errors. Changed dev_err to dev_dbg
> where appropriate.
> 
> Signed-off-by: Garrett Giordano <ggiordano@phytec.com>
> ---

Acked-by: Andrew Davis <afd@ti.com>

> -v2
>    - Change from dev_info to dev_dbg
>    - Drop k3-r5 PATCH
> ---
>   drivers/remoteproc/ti_k3_dsp_remoteproc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> index 3555b535b168..a22d41689a7d 100644
> --- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> @@ -327,7 +327,7 @@ static int k3_dsp_rproc_start(struct rproc *rproc)
>   		goto put_mbox;
>   	}
> 
> -	dev_err(dev, "booting DSP core using boot addr = 0x%x\n", boot_addr);
> +	dev_dbg(dev, "booting DSP core using boot addr = 0x%x\n", boot_addr);
>   	ret = ti_sci_proc_set_config(kproc->tsp, boot_addr, 0, 0);
>   	if (ret)
>   		goto put_mbox;
> --
> 2.25.1
> 
>