[PATCH v2 0/2] perf pmu: Event parsing and listing fixes

James Clark posted 2 patches 1 year, 5 months ago
tools/perf/tests/pmu.c | 78 ++++++++++++++++++++++++++++++++++++++++++
tools/perf/util/pmu.c  | 29 ++++++++++++----
2 files changed, 100 insertions(+), 7 deletions(-)
[PATCH v2 0/2] perf pmu: Event parsing and listing fixes
Posted by James Clark 1 year, 5 months ago
The second fix is related to the discussion here [1].

The first fix is unrelated but I just noticed it while fixing the
listing issue.

[1]: https://lore.kernel.org/all/ce31a50b-53db-4c6f-9cb1-242280b0951c@arm.com/

Changes since v1:

 * Add Ian's suggested-by tag on patch 2
 * Fix mistake where info.pmu_name instead of pmu->name should have
   been used in perf_pmu__for_each_event()

James Clark (2):
  perf pmu: Restore full PMU name wildcard support
  perf pmu: Don't de-duplicate core PMUs

 tools/perf/tests/pmu.c | 78 ++++++++++++++++++++++++++++++++++++++++++
 tools/perf/util/pmu.c  | 29 ++++++++++++----
 2 files changed, 100 insertions(+), 7 deletions(-)

-- 
2.34.1
Re: [PATCH v2 0/2] perf pmu: Event parsing and listing fixes
Posted by Namhyung Kim 1 year, 5 months ago
On Wed, 26 Jun 2024 15:54:44 +0100, James Clark wrote:

> The second fix is related to the discussion here [1].
> 
> The first fix is unrelated but I just noticed it while fixing the
> listing issue.
> 
> [1]: https://lore.kernel.org/all/ce31a50b-53db-4c6f-9cb1-242280b0951c@arm.com/
> 
> [...]

Applied to perf-tools-next, thanks!

Best regards,
Namhyung
Re: [PATCH v2 0/2] perf pmu: Event parsing and listing fixes
Posted by Ian Rogers 1 year, 5 months ago
On Wed, Jun 26, 2024 at 7:55 AM James Clark <james.clark@arm.com> wrote:
>
> The second fix is related to the discussion here [1].
>
> The first fix is unrelated but I just noticed it while fixing the
> listing issue.
>
> [1]: https://lore.kernel.org/all/ce31a50b-53db-4c6f-9cb1-242280b0951c@arm.com/
>
> Changes since v1:
>
>  * Add Ian's suggested-by tag on patch 2
>  * Fix mistake where info.pmu_name instead of pmu->name should have
>    been used in perf_pmu__for_each_event()
>
> James Clark (2):
>   perf pmu: Restore full PMU name wildcard support
>   perf pmu: Don't de-duplicate core PMUs

Reviewed-by: Ian Rogers <irogers@google.com>

Looking forward to an update on the bugs in:
https://lore.kernel.org/lkml/CAP-5=fWxdZ1ibv7Pi0L38+NF-vNWZCtcDS9JVf6k3z9nDsrQQw@mail.gmail.com/

Thanks,
Ian


>  tools/perf/tests/pmu.c | 78 ++++++++++++++++++++++++++++++++++++++++++
>  tools/perf/util/pmu.c  | 29 ++++++++++++----
>  2 files changed, 100 insertions(+), 7 deletions(-)
>
> --
> 2.34.1
>
Re: [PATCH v2 0/2] perf pmu: Event parsing and listing fixes
Posted by James Clark 1 year, 5 months ago
>On Wed, Jun 26, 2024 at 7:55 AM James Clark <james.clark@arm.com> wrote:
>>
>> The second fix is related to the discussion here [1].
>>
>> The first fix is unrelated but I just noticed it while fixing the
>> listing issue.
>>
>> [1]: https://lore.kernel.org/all/ce31a50b-53db-4c6f-9cb1-242280b0951c@arm.com/
>>
>> Changes since v1:
>>
>>  * Add Ian's suggested-by tag on patch 2
>>  * Fix mistake where info.pmu_name instead of pmu->name should have
>>    been used in perf_pmu__for_each_event()
>>
>> James Clark (2):
>>   perf pmu: Restore full PMU name wildcard support
>>   perf pmu: Don't de-duplicate core PMUs
>
>Reviewed-by: Ian Rogers <irogers@google.com>
>
>Looking forward to an update on the bugs in:
>https://lore.kernel.org/lkml/CAP-5=fWxdZ1ibv7Pi0L38+NF-vNWZCtcDS9JVf6k3z9nDsrQQw@mail.gmail.com/
>
>Thanks,
>Ian

Hi Ian,

Thanks for the review. I'm just finishing off one Coresight thing and
then I'll start the big.little default events one:
https://lore.kernel.org/lkml/20240510053705.2462258-4-irogers@google.com/

Thanks
James