[PATCH] selftests/alsa:Fix printf format string in pcm-test.c

Zhu Jun posted 1 patch 1 year, 5 months ago
tools/testing/selftests/alsa/pcm-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] selftests/alsa:Fix printf format string in pcm-test.c
Posted by Zhu Jun 1 year, 5 months ago
Inside of test_pcm_time() arguments are printed via printf
but '%d' is used to print @flags (of type unsigned int).
Use '%u' instead, just like we do everywhere else.

Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 tools/testing/selftests/alsa/pcm-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/alsa/pcm-test.c b/tools/testing/selftests/alsa/pcm-test.c
index de664dedb541..914efcdce1ec 100644
--- a/tools/testing/selftests/alsa/pcm-test.c
+++ b/tools/testing/selftests/alsa/pcm-test.c
@@ -383,7 +383,7 @@ static void test_pcm_time(struct pcm_data *data, enum test_class class,
 		goto __close;
 	}
 	if (rrate != rate) {
-		snprintf(msg, sizeof(msg), "rate mismatch %ld != %d", rate, rrate);
+		snprintf(msg, sizeof(msg), "rate mismatch %ld != %u", rate, rrate);
 		goto __close;
 	}
 	rperiod_size = period_size;
-- 
2.17.1
Re: [PATCH] selftests/alsa:Fix printf format string in pcm-test.c
Posted by Takashi Iwai 1 year, 5 months ago
On Wed, 26 Jun 2024 10:48:59 +0200,
Zhu Jun wrote:
> 
> Inside of test_pcm_time() arguments are printed via printf
> but '%d' is used to print @flags (of type unsigned int).
> Use '%u' instead, just like we do everywhere else.
> 
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>

Applied now to for-next branch.  Thanks.


Takashi
Re: [PATCH] selftests/alsa:Fix printf format string in pcm-test.c
Posted by Mark Brown 1 year, 5 months ago
On Wed, Jun 26, 2024 at 01:48:59AM -0700, Zhu Jun wrote:
> Inside of test_pcm_time() arguments are printed via printf
> but '%d' is used to print @flags (of type unsigned int).
> Use '%u' instead, just like we do everywhere else.
> 
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>

Reviewed-by: Mark Brown <broonie@kernel.org>