The issue is introduced with:

[PATCH v4 0/8] Move camss version related defs in to resources

Signed-off-by: Gjorgji Rosikopulos <quic_grosikop@quicinc.com>
---
 drivers/media/platform/qcom/camss/camss-csid-gen2.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen2.c b/drivers/media/platform/qcom/camss/camss-csid-gen2.c
index 2d8398a91fc2..e1c757933e27 100644
--- a/drivers/media/platform/qcom/camss/camss-csid-gen2.c
+++ b/drivers/media/platform/qcom/camss/camss-csid-gen2.c
@@ -260,17 +260,12 @@ static void __csid_configure_testgen(struct csid_device *csid, u8 enable, u8 vc)
 
 static void __csid_configure_rdi_stream(struct csid_device *csid, u8 enable, u8 vc)
 {
-	struct csid_testgen_config *tg = &csid->testgen;
-	u32 val;
-	u32 phy_sel = 0;
 	/* Source pads matching RDI channels on hardware. Pad 1 -> RDI0, Pad 2 -> RDI1, etc. */
 	struct v4l2_mbus_framefmt *input_format = &csid->fmt[MSM_CSID_PAD_FIRST_SRC + vc];
 	const struct csid_format_info *format = csid_get_fmt_entry(csid->res->formats->formats,
 								   csid->res->formats->nformats,
 								   input_format->code);
-
-	if (!tg->enabled)
-		phy_sel = csid->phy.csiphy_id;
+	u32 val;
 
 	/*
 	 * DT_ID is a two bit bitfield that is concatenated with
-- 
2.17.1

On 26/06/2024 09:47, Gjorgji Rosikopulos wrote:
> The issue is introduced with:
> 
> [PATCH v4 0/8] Move camss version related defs in to resources

In the pull request I posted today I folded this patch into that 6/8 of the
patch series, rather than having this patch on top.

I forgot to mention that in my PR.

Regards,

	Hans

> 
> Signed-off-by: Gjorgji Rosikopulos <quic_grosikop@quicinc.com>
> ---
>  drivers/media/platform/qcom/camss/camss-csid-gen2.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen2.c b/drivers/media/platform/qcom/camss/camss-csid-gen2.c
> index 2d8398a91fc2..e1c757933e27 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid-gen2.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid-gen2.c
> @@ -260,17 +260,12 @@ static void __csid_configure_testgen(struct csid_device *csid, u8 enable, u8 vc)
>  
>  static void __csid_configure_rdi_stream(struct csid_device *csid, u8 enable, u8 vc)
>  {
> -	struct csid_testgen_config *tg = &csid->testgen;
> -	u32 val;
> -	u32 phy_sel = 0;
>  	/* Source pads matching RDI channels on hardware. Pad 1 -> RDI0, Pad 2 -> RDI1, etc. */
>  	struct v4l2_mbus_framefmt *input_format = &csid->fmt[MSM_CSID_PAD_FIRST_SRC + vc];
>  	const struct csid_format_info *format = csid_get_fmt_entry(csid->res->formats->formats,
>  								   csid->res->formats->nformats,
>  								   input_format->code);
> -
> -	if (!tg->enabled)
> -		phy_sel = csid->phy.csiphy_id;
> +	u32 val;
>  
>  	/*
>  	 * DT_ID is a two bit bitfield that is concatenated with

Hi Hans,

On 6/28/2024 1:00 PM, Hans Verkuil wrote:
> On 26/06/2024 09:47, Gjorgji Rosikopulos wrote:
>> The issue is introduced with:
>>
>> [PATCH v4 0/8] Move camss version related defs in to resources
> 
> In the pull request I posted today I folded this patch into that 6/8 of the
> patch series, rather than having this patch on top.
> 
> I forgot to mention that in my PR.

Thank you for this.

Regards,

~Gjorgji