[PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA

Vyacheslav Frantsishko posted 1 patch 1 year, 5 months ago
There is a newer version of this series
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
1 file changed, 7 insertions(+)
[PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA
Posted by Vyacheslav Frantsishko 1 year, 5 months ago
Signed-off-by: Vyacheslav Frantsishko <itmymaill@gmail.com>

The Vivobook S 16X IPS needs a quirks-table entry for the internal microphone to function properly.
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 1760b5d42460..4e3a8ce690a4 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"),
 		}
 	},
+        {
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "M5602RA"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.45.1
Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA
Posted by Mario Limonciello 1 year, 5 months ago
On 6/26/2024 00:51, Vyacheslav Frantsishko wrote:
> Signed-off-by: Vyacheslav Frantsishko <itmymaill@gmail.com>
> 
> The Vivobook S 16X IPS needs a quirks-table entry for the internal microphone to function properly.
> ---
This is a Ryzen 6000 (YC) product, so this does look like the right 
solution.

Your SoB tag is in the wrong place (should be at end of commit message), 
not sure if ALSA guys can fix that while committing or you need to 
re-submit.

But the content looks fine to me otherwise.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

>   sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 1760b5d42460..4e3a8ce690a4 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"),
>   		}
>   	},
> +        {
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "M5602RA"),
> +		}
> +	},
>   	{
>   		.driver_data = &acp6x_card,
>   		.matches = {
[PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA
Posted by Vyacheslav Frantsishko 1 year, 5 months ago
The Vivobook S 16X IPS needs a quirks-table entry for the internal microphone to function properly.

Signed-off-by: Vyacheslav Frantsishko <itmymaill@gmail.com>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 1760b5d42460..4e3a8ce690a4 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"),
 		}
 	},
+        {
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "M5602RA"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.45.1
Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA
Posted by Mark Brown 1 year, 5 months ago
On Wed, 26 Jun 2024 10:03:34 +0300, Vyacheslav Frantsishko wrote:
> The Vivobook S 16X IPS needs a quirks-table entry for the internal microphone to function properly.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: yc: Fix non-functional mic on ASUS M5602RA
      commit: 63b47f026cc841bd3d3438dd6fccbc394dfead87

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark