[v2] s390/lcs: add missing MODULE_DESCRIPTION() macro

[PATCH v2] s390/lcs: add missing MODULE_DESCRIPTION() macro

Posted by Jeff Johnson 1 year, 5 months ago

With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/net/lcs.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
Changes in v2:
- Modified the description (both in the patch and in the file prolog) per
  feedback from Alexandra
- Link to v1: https://lore.kernel.org/r/20240615-md-s390-drivers-s390-net-v1-1-968cb735f70d@quicinc.com
---
 drivers/s390/net/lcs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
index 25d4e6376591..88db8378325a 100644
--- a/drivers/s390/net/lcs.c
+++ b/drivers/s390/net/lcs.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- *  Linux for S/390 Lan Channel Station Network Driver
+ *  Linux for S/390 LAN channel station device driver
  *
  *  Copyright IBM Corp. 1999, 2009
  *  Author(s): Original Code written by
@@ -2380,5 +2380,6 @@ module_init(lcs_init_module);
 module_exit(lcs_cleanup_module);
 
 MODULE_AUTHOR("Frank Pavlic <fpavlic@de.ibm.com>");
+MODULE_DESCRIPTION("S/390 LAN channel station device driver");
 MODULE_LICENSE("GPL");
 

---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240615-md-s390-drivers-s390-net-78a9068f1004

Re: [PATCH v2] s390/lcs: add missing MODULE_DESCRIPTION() macro

Posted by Alexandra Winter 1 year, 5 months ago


On 25.06.24 18:35, Jeff Johnson wrote:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/net/lcs.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> Changes in v2:
> - Modified the description (both in the patch and in the file prolog) per
>   feedback from Alexandra
> - Link to v1: https://lore.kernel.org/r/20240615-md-s390-drivers-s390-net-v1-1-968cb735f70d@quicinc.com
> ---


Acked-by: Alexandra Winter <wintera@linux.ibm.com>

Re: [PATCH v2] s390/lcs: add missing MODULE_DESCRIPTION() macro

Posted by Alexander Gordeev 1 year, 5 months ago

On Wed, Jun 26, 2024 at 01:50:21PM +0200, Alexandra Winter wrote:
> Acked-by: Alexandra Winter <wintera@linux.ibm.com>

Hi Alexandra,

I guess, this update go via s390 tree together with all other
MODULE_DESCRIPTION ones. It is up to you.

Thanks!

Re: [PATCH v2] s390/lcs: add missing MODULE_DESCRIPTION() macro

Posted by Alexandra Winter 1 year, 5 months ago

On 27.06.24 11:02, Alexander Gordeev wrote:
> On Wed, Jun 26, 2024 at 01:50:21PM +0200, Alexandra Winter wrote:
>> Acked-by: Alexandra Winter <wintera@linux.ibm.com>
> 
> Hi Alexandra,
> 
> I guess, this update go via s390 tree together with all other
> MODULE_DESCRIPTION ones. It is up to you.
> 
> Thanks!
> 

Actually my assumption was that the netdev maintainers will take it via netdev.
There are no dependencies afaict.

But any way is fine with me.

@Dave, @Jakub, please speak up, if you want Alexander to take it.