[PATCH] ipmi: Combine identical if checks

Thorsten Blum posted 1 patch 1 year, 5 months ago
drivers/char/ipmi/ipmi_msghandler.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] ipmi: Combine identical if checks
Posted by Thorsten Blum 1 year, 5 months ago
Check for run_to_completion only once.

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 drivers/char/ipmi/ipmi_msghandler.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index e12b531f5c2f..b7d8eb0a3432 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -4870,12 +4870,12 @@ void ipmi_smi_msg_received(struct ipmi_smi *intf,
 	if (!run_to_completion)
 		spin_lock_irqsave(&intf->waiting_rcv_msgs_lock, flags);
 	list_add_tail(&msg->link, &intf->waiting_rcv_msgs);
-	if (!run_to_completion)
+	if (!run_to_completion) {
 		spin_unlock_irqrestore(&intf->waiting_rcv_msgs_lock,
 				       flags);
-
-	if (!run_to_completion)
 		spin_lock_irqsave(&intf->xmit_msgs_lock, flags);
+	}
+
 	/*
 	 * We can get an asynchronous event or receive message in addition
 	 * to commands we send.
-- 
2.45.2