firmware: qcom: tzmem: export devm_qcom_tzmem_pool_new()

[PATCH] firmware: qcom: tzmem: export devm_qcom_tzmem_pool_new()

Posted by Bartosz Golaszewski 1 year, 5 months ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

EXPORT_SYMBOL_GPL() is missing for devm_qcom_tzmem_pool_new() which
causes build failures with randconfig. Add it and fix the issue.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202406250127.8Pl2kqFp-lkp@intel.com
Fixes: 84f5a7b67b61 ("firmware: qcom: add a dedicated TrustZone buffer allocator")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/firmware/qcom/qcom_tzmem.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/qcom/qcom_tzmem.c b/drivers/firmware/qcom/qcom_tzmem.c
index aab6376cade5..5d526753183d 100644
--- a/drivers/firmware/qcom/qcom_tzmem.c
+++ b/drivers/firmware/qcom/qcom_tzmem.c
@@ -324,6 +324,7 @@ devm_qcom_tzmem_pool_new(struct device *dev,
 
 	return pool;
 }
+EXPORT_SYMBOL_GPL(devm_qcom_tzmem_pool_new);
 
 static bool qcom_tzmem_try_grow_pool(struct qcom_tzmem_pool *pool,
 				     size_t requested, gfp_t gfp)
-- 
2.43.0

Re: [PATCH] firmware: qcom: tzmem: export devm_qcom_tzmem_pool_new()

Posted by Bjorn Andersson 1 year, 5 months ago

On Mon, 24 Jun 2024 21:06:14 +0200, Bartosz Golaszewski wrote:
> EXPORT_SYMBOL_GPL() is missing for devm_qcom_tzmem_pool_new() which
> causes build failures with randconfig. Add it and fix the issue.
> 
> 

Applied, thanks!

[1/1] firmware: qcom: tzmem: export devm_qcom_tzmem_pool_new()
      commit: d96377892dd89bd4e7e5ae7293647f6bc7bddf7d

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] firmware: qcom: tzmem: export devm_qcom_tzmem_pool_new()

Posted by Elliot Berman 1 year, 5 months ago

On Mon, Jun 24, 2024 at 09:06:14PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> EXPORT_SYMBOL_GPL() is missing for devm_qcom_tzmem_pool_new() which
> causes build failures with randconfig. Add it and fix the issue.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406250127.8Pl2kqFp-lkp@intel.com
> Fixes: 84f5a7b67b61 ("firmware: qcom: add a dedicated TrustZone buffer allocator")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Elliot Berman <quic_eberman@quicinc.com>

> ---
>  drivers/firmware/qcom/qcom_tzmem.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/qcom/qcom_tzmem.c b/drivers/firmware/qcom/qcom_tzmem.c
> index aab6376cade5..5d526753183d 100644
> --- a/drivers/firmware/qcom/qcom_tzmem.c
> +++ b/drivers/firmware/qcom/qcom_tzmem.c
> @@ -324,6 +324,7 @@ devm_qcom_tzmem_pool_new(struct device *dev,
>  
>  	return pool;
>  }
> +EXPORT_SYMBOL_GPL(devm_qcom_tzmem_pool_new);
>  
>  static bool qcom_tzmem_try_grow_pool(struct qcom_tzmem_pool *pool,
>  				     size_t requested, gfp_t gfp)
> -- 
> 2.43.0
>

Re: [PATCH] firmware: qcom: tzmem: export devm_qcom_tzmem_pool_new()

Posted by Andrew Halaney 1 year, 5 months ago

On Mon, Jun 24, 2024 at 09:06:14PM GMT, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> EXPORT_SYMBOL_GPL() is missing for devm_qcom_tzmem_pool_new() which
> causes build failures with randconfig. Add it and fix the issue.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406250127.8Pl2kqFp-lkp@intel.com
> Fixes: 84f5a7b67b61 ("firmware: qcom: add a dedicated TrustZone buffer allocator")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Andrew Halaney <ahalaney@redhat.com>

> ---
>  drivers/firmware/qcom/qcom_tzmem.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/qcom/qcom_tzmem.c b/drivers/firmware/qcom/qcom_tzmem.c
> index aab6376cade5..5d526753183d 100644
> --- a/drivers/firmware/qcom/qcom_tzmem.c
> +++ b/drivers/firmware/qcom/qcom_tzmem.c
> @@ -324,6 +324,7 @@ devm_qcom_tzmem_pool_new(struct device *dev,
>  
>  	return pool;
>  }
> +EXPORT_SYMBOL_GPL(devm_qcom_tzmem_pool_new);
>  
>  static bool qcom_tzmem_try_grow_pool(struct qcom_tzmem_pool *pool,
>  				     size_t requested, gfp_t gfp)
> -- 
> 2.43.0
> 
>