[PATCH v2 5/8] Add debug log info to camss_enable_clocks function

George Chan via B4 Relay posted 8 patches 1 year, 5 months ago
There is a newer version of this series
[PATCH v2 5/8] Add debug log info to camss_enable_clocks function
Posted by George Chan via B4 Relay 1 year, 5 months ago
From: George Chan <gchan9527@gmail.com>

Print out missing clock's name when doing camss_enable_clocks().

Signed-off-by: George Chan <gchan9527@gmail.com>
---
 drivers/media/platform/qcom/camss/camss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index 86ba80c47188..d50f98565531 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -1467,7 +1467,7 @@ int camss_enable_clocks(int nclocks, struct camss_clock *clock,
 	for (i = 0; i < nclocks; i++) {
 		ret = clk_prepare_enable(clock[i].clk);
 		if (ret) {
-			dev_err(dev, "clock enable failed: %d\n", ret);
+			dev_err(dev, "clock enable failed: %s %d\n", clock[i].name, ret);
 			goto error;
 		}
 	}

-- 
2.34.1
Re: [PATCH v2 5/8] Add debug log info to camss_enable_clocks function
Posted by Bryan O'Donoghue 1 year, 5 months ago
On 24/06/2024 00:22, George Chan via B4 Relay wrote:
> From: George Chan <gchan9527@gmail.com>
> 
> Print out missing clock's name when doing camss_enable_clocks().
> 
> Signed-off-by: George Chan <gchan9527@gmail.com>
> ---
>   drivers/media/platform/qcom/camss/camss.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 86ba80c47188..d50f98565531 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -1467,7 +1467,7 @@ int camss_enable_clocks(int nclocks, struct camss_clock *clock,
>   	for (i = 0; i < nclocks; i++) {
>   		ret = clk_prepare_enable(clock[i].clk);
>   		if (ret) {
> -			dev_err(dev, "clock enable failed: %d\n", ret);
> +			dev_err(dev, "clock enable failed: %s %d\n", clock[i].name, ret);
>   			goto error;
>   		}
>   	}
> 

Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>