netlink: specs: Fix pse-set command attributes

[PATCH net] netlink: specs: Fix pse-set command attributes

Posted by Kory Maincent 1 year, 5 months ago

Not all PSE attributes are used for the pse-set netlink command.
Select only the ones used by ethtool.

Fixes: f8586411e40e ("netlink: specs: Expand the pse netlink command with PoE interface")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 Documentation/netlink/specs/ethtool.yaml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 00dc61358be8..4510e8d1adcb 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -1603,7 +1603,7 @@ operations:
           attributes:
             - header
         reply:
-          attributes: &pse
+          attributes:
             - header
             - podl-pse-admin-state
             - podl-pse-admin-control
@@ -1620,7 +1620,10 @@ operations:
 
       do:
         request:
-          attributes: *pse
+          attributes:
+            - header
+            - podl-pse-admin-control
+            - c33-pse-admin-control
     -
       name: rss-get
       doc: Get RSS params.
-- 
2.34.1

Re: [PATCH net] netlink: specs: Fix pse-set command attributes

Posted by Donald Hunter 1 year, 5 months ago

Kory Maincent <kory.maincent@bootlin.com> writes:

> Not all PSE attributes are used for the pse-set netlink command.
> Select only the ones used by ethtool.
>
> Fixes: f8586411e40e ("netlink: specs: Expand the pse netlink command with PoE interface")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>