[PATCH] sched/preempt: Bypass setting same mode for sched_dynamic_update()

Jinjie Ruan posted 1 patch 1 year, 7 months ago
kernel/sched/core.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH] sched/preempt: Bypass setting same mode for sched_dynamic_update()
Posted by Jinjie Ruan 1 year, 7 months ago
If the preempt mode to set is same with current preempt mode, there is no
need to update all the `cond_resched`, `might_resched`, `preempt_schedule`,
`preempt_schedule_notrace` and `irqentry_exit_cond_resched` state.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
 kernel/sched/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index bcf2c4cc0522..eb409901c64c 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -8777,6 +8777,9 @@ static bool klp_override;
 
 static void __sched_dynamic_update(int mode)
 {
+	if (mode == preempt_dynamic_mode)
+		return;
+
 	/*
 	 * Avoid {NONE,VOLUNTARY} -> FULL transitions from ever ending up in
 	 * the ZERO state, which is invalid.
-- 
2.34.1
Re: [PATCH] sched/preempt: Bypass setting same mode for sched_dynamic_update()
Posted by Peter Zijlstra 1 year, 7 months ago
On Thu, Jun 20, 2024 at 08:10:20PM +0800, Jinjie Ruan wrote:
> If the preempt mode to set is same with current preempt mode, there is no
> need to update all the `cond_resched`, `might_resched`, `preempt_schedule`,
> `preempt_schedule_notrace` and `irqentry_exit_cond_resched` state.

IIRC this actively breaks things, also this is a super slow path, nobody
should care.

> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
>  kernel/sched/core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index bcf2c4cc0522..eb409901c64c 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -8777,6 +8777,9 @@ static bool klp_override;
>  
>  static void __sched_dynamic_update(int mode)
>  {
> +	if (mode == preempt_dynamic_mode)
> +		return;
> +
>  	/*
>  	 * Avoid {NONE,VOLUNTARY} -> FULL transitions from ever ending up in
>  	 * the ZERO state, which is invalid.
> -- 
> 2.34.1
>