[PATCH v3 7/8] ARM: stm32: allow build irq-stm32mp-exti driver as module

Antonio Borneo posted 8 patches 1 year, 5 months ago
[PATCH v3 7/8] ARM: stm32: allow build irq-stm32mp-exti driver as module
Posted by Antonio Borneo 1 year, 5 months ago
Drop auto-selecting the driver, so it can be built either as a
module or built-in.

Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
---
 arch/arm/mach-stm32/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-stm32/Kconfig b/arch/arm/mach-stm32/Kconfig
index a401a991fe088..630b992f32b16 100644
--- a/arch/arm/mach-stm32/Kconfig
+++ b/arch/arm/mach-stm32/Kconfig
@@ -11,7 +11,6 @@ menuconfig ARCH_STM32
 	select CLKSRC_STM32
 	select PINCTRL
 	select RESET_CONTROLLER
-	select STM32MP_EXTI if ARCH_MULTI_V7
 	select STM32_EXTI if ARM_SINGLE_ARMV7M
 	select STM32_FIREWALL
 	help
-- 
2.34.1
Re: [PATCH v3 7/8] ARM: stm32: allow build irq-stm32mp-exti driver as module
Posted by Thomas Gleixner 1 year, 5 months ago
On Thu, Jun 20 2024 at 10:31, Antonio Borneo wrote:

> Drop auto-selecting the driver, so it can be built either as a
> module or built-in.

How is the driver selected then? Has this to be done manually now?

If so, doesn't that break things when starting from an empty config?

Thanks,

        tglx
Re: [PATCH v3 7/8] ARM: stm32: allow build irq-stm32mp-exti driver as module
Posted by Antonio Borneo 1 year, 5 months ago
On Sun, 2024-06-23 at 19:27 +0200, Thomas Gleixner wrote:
> On Thu, Jun 20 2024 at 10:31, Antonio Borneo wrote:
> 
> > Drop auto-selecting the driver, so it can be built either as a
> > module or built-in.
> 
> How is the driver selected then? Has this to be done manually now?
> 
> If so, doesn't that break things when starting from an empty config?

In patch 6/8 it is already selected through:

+	depends on (ARCH_STM32 && !ARM_SINGLE_ARMV7M) || COMPILE_TEST
+	default y

Regards,
Antonio
Re: [PATCH v3 7/8] ARM: stm32: allow build irq-stm32mp-exti driver as module
Posted by Thomas Gleixner 1 year, 5 months ago
On Sun, Jun 23 2024 at 19:38, Antonio Borneo wrote:
> On Sun, 2024-06-23 at 19:27 +0200, Thomas Gleixner wrote:
>> On Thu, Jun 20 2024 at 10:31, Antonio Borneo wrote:
>> 
>> > Drop auto-selecting the driver, so it can be built either as a
>> > module or built-in.
>> 
>> How is the driver selected then? Has this to be done manually now?
>> 
>> If so, doesn't that break things when starting from an empty config?
>
> In patch 6/8 it is already selected through:
>
> +	depends on (ARCH_STM32 && !ARM_SINGLE_ARMV7M) || COMPILE_TEST
> +	default y

Missed that. Thanks for the clarification!

       tglx
[tip: irq/core] ARM: stm32: Allow build irq-stm32mp-exti driver as module
Posted by tip-bot2 for Antonio Borneo 1 year, 5 months ago
The following commit has been merged into the irq/core branch of tip:

Commit-ID:     2751ee69c150fa3013924cadba6f47eb7215086f
Gitweb:        https://git.kernel.org/tip/2751ee69c150fa3013924cadba6f47eb7215086f
Author:        Antonio Borneo <antonio.borneo@foss.st.com>
AuthorDate:    Thu, 20 Jun 2024 10:31:14 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Mon, 24 Jun 2024 00:16:43 +02:00

ARM: stm32: Allow build irq-stm32mp-exti driver as module

Drop auto-selecting the driver, so it can be built either as a module or
built-in.

Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240620083115.204362-8-antonio.borneo@foss.st.com

---
 arch/arm/mach-stm32/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-stm32/Kconfig b/arch/arm/mach-stm32/Kconfig
index a401a99..630b992 100644
--- a/arch/arm/mach-stm32/Kconfig
+++ b/arch/arm/mach-stm32/Kconfig
@@ -11,7 +11,6 @@ menuconfig ARCH_STM32
 	select CLKSRC_STM32
 	select PINCTRL
 	select RESET_CONTROLLER
-	select STM32MP_EXTI if ARCH_MULTI_V7
 	select STM32_EXTI if ARM_SINGLE_ARMV7M
 	select STM32_FIREWALL
 	help