[PATCH] tty: mcf: MCF54418 has 10 UARTS

Jean-Michel Hautbois posted 1 patch 1 year, 5 months ago
drivers/tty/serial/mcf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] tty: mcf: MCF54418 has 10 UARTS
Posted by Jean-Michel Hautbois 1 year, 5 months ago
Most of the colfires have up to 5 UARTs but MCF54418 has up-to 10 !
Change the maximum value authorized.

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>
---
 drivers/tty/serial/mcf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
index b0604d6da025..58858dd352c5 100644
--- a/drivers/tty/serial/mcf.c
+++ b/drivers/tty/serial/mcf.c
@@ -462,7 +462,7 @@ static const struct uart_ops mcf_uart_ops = {
 	.verify_port	= mcf_verify_port,
 };
 
-static struct mcf_uart mcf_ports[4];
+static struct mcf_uart mcf_ports[10];
 
 #define	MCF_MAXPORTS	ARRAY_SIZE(mcf_ports)
 

---
base-commit: e5b3efbe1ab1793bb49ae07d56d0973267e65112
change-id: 20240620-upstream-uart-c7fc1f79e842

Best regards,
-- 
Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>
Re: [PATCH] tty: mcf: MCF54418 has 10 UARTS
Posted by Greg Kroah-Hartman 1 year, 5 months ago
On Thu, Jun 20, 2024 at 06:29:59PM +0200, Jean-Michel Hautbois wrote:
> Most of the colfires have up to 5 UARTs but MCF54418 has up-to 10 !
> Change the maximum value authorized.
> 
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>
> ---
>  drivers/tty/serial/mcf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
> index b0604d6da025..58858dd352c5 100644
> --- a/drivers/tty/serial/mcf.c
> +++ b/drivers/tty/serial/mcf.c
> @@ -462,7 +462,7 @@ static const struct uart_ops mcf_uart_ops = {
>  	.verify_port	= mcf_verify_port,
>  };
>  
> -static struct mcf_uart mcf_ports[4];
> +static struct mcf_uart mcf_ports[10];

What commit id does this fix?

thanks,

greg k-h
Re: [PATCH] tty: mcf: MCF54418 has 10 UARTS
Posted by Jean-Michel Hautbois 1 year, 5 months ago
Hi Greg,

On 20/06/2024 18:58, Greg Kroah-Hartman wrote:
> On Thu, Jun 20, 2024 at 06:29:59PM +0200, Jean-Michel Hautbois wrote:
>> Most of the colfires have up to 5 UARTs but MCF54418 has up-to 10 !
>> Change the maximum value authorized.
>>
>> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>
>> ---
>>   drivers/tty/serial/mcf.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
>> index b0604d6da025..58858dd352c5 100644
>> --- a/drivers/tty/serial/mcf.c
>> +++ b/drivers/tty/serial/mcf.c
>> @@ -462,7 +462,7 @@ static const struct uart_ops mcf_uart_ops = {
>>   	.verify_port	= mcf_verify_port,
>>   };
>>   
>> -static struct mcf_uart mcf_ports[4];
>> +static struct mcf_uart mcf_ports[10];
> 
> What commit id does this fix?

Sorry about that !
Fixes: 2545cf6e94b4 (m68knommu: allow 4 coldfire serial ports, 2010-03-18)

> 
> thanks,
> 
> greg k-h