drm: Remove unused function rcar_cmm_write

[PATCH] drm: Remove unused function rcar_cmm_write

Posted by Jiapeng Chong 1 year, 7 months ago

The function are defined in the rcar_cmm.c file, but not called
elsewhere, so delete the unused function.

drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function 'rcar_cmm_read'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9364
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
index 26a2f5ad8ee5..883b960e9acc 100644
--- a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
+++ b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
@@ -32,11 +32,6 @@ struct rcar_cmm {
 	} lut;
 };
 
-static inline int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg)
-{
-	return ioread32(rcmm->base + reg);
-}
-
 static inline void rcar_cmm_write(struct rcar_cmm *rcmm, u32 reg, u32 data)
 {
 	iowrite32(data, rcmm->base + reg);
-- 
2.20.1.7.g153144c

Re: [PATCH] drm: Remove unused function rcar_cmm_write

Posted by Kieran Bingham 1 year, 7 months ago

Quoting Jiapeng Chong (2024-06-19 08:54:36)
> The function are defined in the rcar_cmm.c file, but not called
> elsewhere, so delete the unused function.
> 
> drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function 'rcar_cmm_read'.

Indeed it's unused.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9364
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> index 26a2f5ad8ee5..883b960e9acc 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> @@ -32,11 +32,6 @@ struct rcar_cmm {
>         } lut;
>  };
>  
> -static inline int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg)
> -{
> -       return ioread32(rcmm->base + reg);
> -}
> -
>  static inline void rcar_cmm_write(struct rcar_cmm *rcmm, u32 reg, u32 data)
>  {
>         iowrite32(data, rcmm->base + reg);
> -- 
> 2.20.1.7.g153144c
>

Re: [PATCH] drm: Remove unused function rcar_cmm_write

Posted by Sergey Shtylyov 1 year, 7 months ago

On 6/19/24 10:54 AM, Jiapeng Chong wrote:

> The function are defined in the rcar_cmm.c file, but not called

   s/are/is/.

> elsewhere, so delete the unused function.

   Anywhere, maybe?

> drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function 'rcar_cmm_read'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9364
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

[...]

MBR, Sergey

Re: [PATCH] drm: Remove unused function rcar_cmm_write

Posted by Laurent Pinchart 1 year, 7 months ago

On Wed, Jun 19, 2024 at 12:16:47PM +0300, Sergey Shtylyov wrote:
> On 6/19/24 10:54 AM, Jiapeng Chong wrote:
> 
> > The function are defined in the rcar_cmm.c file, but not called
> 
>    s/are/is/.
> 
> > elsewhere, so delete the unused function.
> 
>    Anywhere, maybe?

I'll fix those.

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> > drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function 'rcar_cmm_read'.
> > 
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9364
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> 
> [...]

-- 
Regards,

Laurent Pinchart