[PATCH] ASoC: dt-bindings: rename wm8750.yaml to wlf,wm8750.yaml

Animesh Agarwal posted 1 patch 1 year, 7 months ago
.../devicetree/bindings/sound/{wm8750.yaml => wlf,wm8750.yaml}  | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
rename Documentation/devicetree/bindings/sound/{wm8750.yaml => wlf,wm8750.yaml} (92%)
[PATCH] ASoC: dt-bindings: rename wm8750.yaml to wlf,wm8750.yaml
Posted by Animesh Agarwal 1 year, 7 months ago
Add vendor prefix to wlf,wm8750 dt-schema.

Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>
---
 .../devicetree/bindings/sound/{wm8750.yaml => wlf,wm8750.yaml}  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename Documentation/devicetree/bindings/sound/{wm8750.yaml => wlf,wm8750.yaml} (92%)

diff --git a/Documentation/devicetree/bindings/sound/wm8750.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8750.yaml
similarity index 92%
rename from Documentation/devicetree/bindings/sound/wm8750.yaml
rename to Documentation/devicetree/bindings/sound/wlf,wm8750.yaml
index 24246ac7bbdf..96859e38315b 100644
--- a/Documentation/devicetree/bindings/sound/wm8750.yaml
+++ b/Documentation/devicetree/bindings/sound/wlf,wm8750.yaml
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/sound/wm8750.yaml#
+$id: http://devicetree.org/schemas/sound/wlf,wm8750.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: WM8750 and WM8987 audio CODECs
-- 
2.45.2
Re: [PATCH] ASoC: dt-bindings: rename wm8750.yaml to wlf,wm8750.yaml
Posted by Krzysztof Kozlowski 1 year, 7 months ago
On 19/06/2024 09:03, Animesh Agarwal wrote:
> Add vendor prefix to wlf,wm8750 dt-schema.
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> ---
>  .../devicetree/bindings/sound/{wm8750.yaml => wlf,wm8750.yaml}  | 2 +-

Same as in other cases (why they started now?): why only one file not
all of them? Anyway, that's not necessary.

Best regards,
Krzysztof
Re: [PATCH] ASoC: dt-bindings: rename wm8750.yaml to wlf,wm8750.yaml
Posted by Daniel Baluta 1 year, 7 months ago
On Wed, Jun 19, 2024 at 10:29 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 19/06/2024 09:03, Animesh Agarwal wrote:
> > Add vendor prefix to wlf,wm8750 dt-schema.
> >
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
> >  .../devicetree/bindings/sound/{wm8750.yaml => wlf,wm8750.yaml}  | 2 +-
>
> Same as in other cases (why they started now?): why only one file not
> all of them? Anyway, that's not necessary.

There is only one yaml file from wolfson which doesnt have the wlf, prefix.
For consistency we think that we should rename the file :).
Re: [PATCH] ASoC: dt-bindings: rename wm8750.yaml to wlf,wm8750.yaml
Posted by Krzysztof Kozlowski 1 year, 7 months ago
On 20/06/2024 08:08, Daniel Baluta wrote:
> On Wed, Jun 19, 2024 at 10:29 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 19/06/2024 09:03, Animesh Agarwal wrote:
>>> Add vendor prefix to wlf,wm8750 dt-schema.
>>>
>>> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
>>> Cc: Daniel Baluta <daniel.baluta@nxp.com>
>>> ---
>>>  .../devicetree/bindings/sound/{wm8750.yaml => wlf,wm8750.yaml}  | 2 +-
>>
>> Same as in other cases (why they started now?): why only one file not
>> all of them? Anyway, that's not necessary.
> 
> There is only one yaml file from wolfson which doesnt have the wlf, prefix.
> For consistency we think that we should rename the file :).

And several other files have the same issue. That's just churn. No, let
me be clear. Rule is for all files, not for wlf or asahi only. If you
want that consistency, then fix *all* files, not selected one schema.

Best regards,
Krzysztof

Re: [PATCH] ASoC: dt-bindings: rename wm8750.yaml to wlf,wm8750.yaml
Posted by Krzysztof Kozlowski 1 year, 7 months ago
On 20/06/2024 08:37, Krzysztof Kozlowski wrote:
> On 20/06/2024 08:08, Daniel Baluta wrote:
>> On Wed, Jun 19, 2024 at 10:29 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>
>>> On 19/06/2024 09:03, Animesh Agarwal wrote:
>>>> Add vendor prefix to wlf,wm8750 dt-schema.
>>>>
>>>> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
>>>> Cc: Daniel Baluta <daniel.baluta@nxp.com>
>>>> ---
>>>>  .../devicetree/bindings/sound/{wm8750.yaml => wlf,wm8750.yaml}  | 2 +-
>>>
>>> Same as in other cases (why they started now?): why only one file not
>>> all of them? Anyway, that's not necessary.
>>
>> There is only one yaml file from wolfson which doesnt have the wlf, prefix.
>> For consistency we think that we should rename the file :).
> 
> And several other files have the same issue. That's just churn. No, let
> me be clear. Rule is for all files, not for wlf or asahi only. If you
> want that consistency, then fix *all* files, not selected one schema.

I see now Kuninori went by my previous suggestion, so this patch is not
needed/obsolete.

Best regards,
Krzysztof