pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc()

[PATCH RFT] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc()

Posted by Bartosz Golaszewski 1 year, 7 months ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

In order to finally confine the unsafe gpiochip_get_desc() to
drivers/gpio/, let's convert this driver to using the safer alternative
that takes the gpio_device as argument.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/pinctrl/pinctrl-da9062.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
index 22e3cd2cc963..6f44a13b90ce 100644
--- a/drivers/pinctrl/pinctrl-da9062.c
+++ b/drivers/pinctrl/pinctrl-da9062.c
@@ -139,7 +139,7 @@ static int da9062_gpio_direction_input(struct gpio_chip *gc,
 {
 	struct da9062_pctl *pctl = gpiochip_get_data(gc);
 	struct regmap *regmap = pctl->da9062->regmap;
-	struct gpio_desc *desc = gpiochip_get_desc(gc, offset);
+	struct gpio_desc *desc = gpio_device_get_desc(gc->gpiodev, offset);
 	unsigned int gpi_type;
 	int ret;
 
-- 
2.43.0

Re: [PATCH RFT] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc()

Posted by Bartosz Golaszewski 1 year, 7 months ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Tue, 18 Jun 2024 13:18:24 +0200, Bartosz Golaszewski wrote:
> In order to finally confine the unsafe gpiochip_get_desc() to
> drivers/gpio/, let's convert this driver to using the safer alternative
> that takes the gpio_device as argument.
> 
> 

Applied, thanks!

[1/1] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc()
      commit: 8657af6c0a9afaa11947b7476119834898823b52

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH RFT] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc()

Posted by Linus Walleij 1 year, 7 months ago

On Tue, Jun 18, 2024 at 1:18 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> In order to finally confine the unsafe gpiochip_get_desc() to
> drivers/gpio/, let's convert this driver to using the safer alternative
> that takes the gpio_device as argument.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

I guess you will apply this to the GPIO tree, else tell me what to do!

Yours,
Linus Walleij

Re: [PATCH RFT] pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc()

Posted by Bartosz Golaszewski 1 year, 7 months ago

On Tue, Jun 18, 2024 at 1:27 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Jun 18, 2024 at 1:18 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > In order to finally confine the unsafe gpiochip_get_desc() to
> > drivers/gpio/, let's convert this driver to using the safer alternative
> > that takes the gpio_device as argument.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> I guess you will apply this to the GPIO tree, else tell me what to do!
>
> Yours,
> Linus Walleij

I can, yes. Thank you.

I'll give it some time to possibly get a Tested-by from Dialog.

Bart