[v1] fgraph: Use str_plural() in test_graph_storage_single()

[PATCH] fgraph: Use str_plural() in test_graph_storage_single()

Posted by Jiapeng Chong 1 year, 6 months ago

Use existing str_plural() function rather than duplicating its
implementation.

./kernel/trace/trace_selftest.c:880:56-60: opportunity for str_plural(size).

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9349
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 kernel/trace/trace_selftest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
index adf0f436d84b..97f1e4bc47dc 100644
--- a/kernel/trace/trace_selftest.c
+++ b/kernel/trace/trace_selftest.c
@@ -877,7 +877,7 @@ static int __init test_graph_storage_single(struct fgraph_fixture *fixture)
 	int ret;
 
 	pr_cont("PASSED\n");
-	pr_info("Testing fgraph storage of %d byte%s: ", size, size > 1 ? "s" : "");
+	pr_info("Testing fgraph storage of %d byte%s: ", size, str_plural(size));
 
 	ret = init_fgraph_fixture(fixture);
 	if (ret && ret != -ENODEV) {
-- 
2.20.1.7.g153144c

Re: [PATCH] fgraph: Use str_plural() in test_graph_storage_single()

Posted by Masami Hiramatsu (Google) 1 year, 6 months ago

On Tue, 18 Jun 2024 15:20:14 +0800
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:

> Use existing str_plural() function rather than duplicating its
> implementation.
> 
> ./kernel/trace/trace_selftest.c:880:56-60: opportunity for str_plural(size).
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9349
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Thanks, this looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>


> ---
>  kernel/trace/trace_selftest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
> index adf0f436d84b..97f1e4bc47dc 100644
> --- a/kernel/trace/trace_selftest.c
> +++ b/kernel/trace/trace_selftest.c
> @@ -877,7 +877,7 @@ static int __init test_graph_storage_single(struct fgraph_fixture *fixture)
>  	int ret;
>  
>  	pr_cont("PASSED\n");
> -	pr_info("Testing fgraph storage of %d byte%s: ", size, size > 1 ? "s" : "");
> +	pr_info("Testing fgraph storage of %d byte%s: ", size, str_plural(size));
>  
>  	ret = init_fgraph_fixture(fixture);
>  	if (ret && ret != -ENODEV) {
> -- 
> 2.20.1.7.g153144c
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>