1. Patchew
  2. linux
  3. View series

[PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location

Adam Ford posted 1 patch 1 year, 6 months ago
[PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location
Posted by Adam Ford 1 year, 6 months ago 
The pgc_mlmix shows a power-domain@24, but the reg value is
IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.

The stuff after the @ symbol should match the stuff referenced
by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.

Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index b92abb5a5c53..3576d2b89b43 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -789,6 +789,23 @@ pgc_usb2_phy: power-domain@3 {
 						reg = <IMX8MP_POWER_DOMAIN_USB2_PHY>;
 					};
 
+					pgc_mlmix: power-domain@4 {
+						#power-domain-cells = <0>;
+						reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
+						clocks = <&clk IMX8MP_CLK_ML_AXI>,
+							 <&clk IMX8MP_CLK_ML_AHB>,
+							 <&clk IMX8MP_CLK_NPU_ROOT>;
+						assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
+								  <&clk IMX8MP_CLK_ML_AXI>,
+								  <&clk IMX8MP_CLK_ML_AHB>;
+						assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
+									 <&clk IMX8MP_SYS_PLL1_800M>,
+									 <&clk IMX8MP_SYS_PLL1_800M>;
+						assigned-clock-rates = <800000000>,
+								       <800000000>,
+								       <300000000>;
+					};
+
 					pgc_audio: power-domain@5 {
 						#power-domain-cells = <0>;
 						reg = <IMX8MP_POWER_DOMAIN_AUDIOMIX>;
@@ -900,23 +917,6 @@ pgc_vpu_vc8000e: power-domain@22 {
 						reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
 						clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
 					};
-
-					pgc_mlmix: power-domain@24 {
-						#power-domain-cells = <0>;
-						reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
-						clocks = <&clk IMX8MP_CLK_ML_AXI>,
-							 <&clk IMX8MP_CLK_ML_AHB>,
-							 <&clk IMX8MP_CLK_NPU_ROOT>;
-						assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
-								  <&clk IMX8MP_CLK_ML_AXI>,
-								  <&clk IMX8MP_CLK_ML_AHB>;
-						assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
-									 <&clk IMX8MP_SYS_PLL1_800M>,
-									 <&clk IMX8MP_SYS_PLL1_800M>;
-						assigned-clock-rates = <800000000>,
-								       <800000000>,
-								       <300000000>;
-					};
 				};
 			};
 		};
-- 
2.43.0
Re: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location
Posted by Shawn Guo 1 year, 5 months ago 
On Mon, Jun 17, 2024 at 05:39:51PM -0500, Adam Ford wrote:
> The pgc_mlmix shows a power-domain@24, but the reg value is
> IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.
> 
> The stuff after the @ symbol should match the stuff referenced
> by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.
> 
> Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
> Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>

Applied, thanks!
Re: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location
Posted by Alexander Stein 1 year, 6 months ago 
Hi Adam,

Am Dienstag, 18. Juni 2024, 00:39:51 CEST schrieb Adam Ford:
> The pgc_mlmix shows a power-domain@24, but the reg value is
> IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.
> 
> The stuff after the @ symbol should match the stuff referenced
> by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.

Taking a look this mismatch seems to be also true for:
* IMX8MP_POWER_DOMAIN_VPUMIX
* IMX8MP_POWER_DOMAIN_VPU_G1
* IMX8MP_POWER_DOMAIN_VPU_G2
* IMX8MP_POWER_DOMAIN_VPU_VC8000E

Would you mind fixing them as well?

Despite that, for this patch:
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Thanks and best regards,
Alexander

> Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
> Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index b92abb5a5c53..3576d2b89b43 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -789,6 +789,23 @@ pgc_usb2_phy: power-domain@3 {
>  						reg = <IMX8MP_POWER_DOMAIN_USB2_PHY>;
>  					};
>  
> +					pgc_mlmix: power-domain@4 {
> +						#power-domain-cells = <0>;
> +						reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
> +						clocks = <&clk IMX8MP_CLK_ML_AXI>,
> +							 <&clk IMX8MP_CLK_ML_AHB>,
> +							 <&clk IMX8MP_CLK_NPU_ROOT>;
> +						assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
> +								  <&clk IMX8MP_CLK_ML_AXI>,
> +								  <&clk IMX8MP_CLK_ML_AHB>;
> +						assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
> +									 <&clk IMX8MP_SYS_PLL1_800M>,
> +									 <&clk IMX8MP_SYS_PLL1_800M>;
> +						assigned-clock-rates = <800000000>,
> +								       <800000000>,
> +								       <300000000>;
> +					};
> +
>  					pgc_audio: power-domain@5 {
>  						#power-domain-cells = <0>;
>  						reg = <IMX8MP_POWER_DOMAIN_AUDIOMIX>;
> @@ -900,23 +917,6 @@ pgc_vpu_vc8000e: power-domain@22 {
>  						reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
>  						clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
>  					};
> -
> -					pgc_mlmix: power-domain@24 {
> -						#power-domain-cells = <0>;
> -						reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
> -						clocks = <&clk IMX8MP_CLK_ML_AXI>,
> -							 <&clk IMX8MP_CLK_ML_AHB>,
> -							 <&clk IMX8MP_CLK_NPU_ROOT>;
> -						assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
> -								  <&clk IMX8MP_CLK_ML_AXI>,
> -								  <&clk IMX8MP_CLK_ML_AHB>;
> -						assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
> -									 <&clk IMX8MP_SYS_PLL1_800M>,
> -									 <&clk IMX8MP_SYS_PLL1_800M>;
> -						assigned-clock-rates = <800000000>,
> -								       <800000000>,
> -								       <300000000>;
> -					};
>  				};
>  			};
>  		};
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
Re: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location
Posted by Adam Ford 1 year, 6 months ago 
On Tue, Jun 18, 2024 at 1:15 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Hi Adam,
>
> Am Dienstag, 18. Juni 2024, 00:39:51 CEST schrieb Adam Ford:
> > The pgc_mlmix shows a power-domain@24, but the reg value is
> > IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.
> >
> > The stuff after the @ symbol should match the stuff referenced
> > by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.
>
> Taking a look this mismatch seems to be also true for:
> * IMX8MP_POWER_DOMAIN_VPUMIX
> * IMX8MP_POWER_DOMAIN_VPU_G1
> * IMX8MP_POWER_DOMAIN_VPU_G2
> * IMX8MP_POWER_DOMAIN_VPU_VC8000E
>
> Would you mind fixing them as well?

I can do that.   I'll send out out later tonight.

adam
>
> Despite that, for this patch:
> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> Thanks and best regards,
> Alexander
>
> > Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
> > Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index b92abb5a5c53..3576d2b89b43 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -789,6 +789,23 @@ pgc_usb2_phy: power-domain@3 {
> >                                               reg = <IMX8MP_POWER_DOMAIN_USB2_PHY>;
> >                                       };
> >
> > +                                     pgc_mlmix: power-domain@4 {
> > +                                             #power-domain-cells = <0>;
> > +                                             reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
> > +                                             clocks = <&clk IMX8MP_CLK_ML_AXI>,
> > +                                                      <&clk IMX8MP_CLK_ML_AHB>,
> > +                                                      <&clk IMX8MP_CLK_NPU_ROOT>;
> > +                                             assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
> > +                                                               <&clk IMX8MP_CLK_ML_AXI>,
> > +                                                               <&clk IMX8MP_CLK_ML_AHB>;
> > +                                             assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
> > +                                                                      <&clk IMX8MP_SYS_PLL1_800M>,
> > +                                                                      <&clk IMX8MP_SYS_PLL1_800M>;
> > +                                             assigned-clock-rates = <800000000>,
> > +                                                                    <800000000>,
> > +                                                                    <300000000>;
> > +                                     };
> > +
> >                                       pgc_audio: power-domain@5 {
> >                                               #power-domain-cells = <0>;
> >                                               reg = <IMX8MP_POWER_DOMAIN_AUDIOMIX>;
> > @@ -900,23 +917,6 @@ pgc_vpu_vc8000e: power-domain@22 {
> >                                               reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
> >                                               clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
> >                                       };
> > -
> > -                                     pgc_mlmix: power-domain@24 {
> > -                                             #power-domain-cells = <0>;
> > -                                             reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
> > -                                             clocks = <&clk IMX8MP_CLK_ML_AXI>,
> > -                                                      <&clk IMX8MP_CLK_ML_AHB>,
> > -                                                      <&clk IMX8MP_CLK_NPU_ROOT>;
> > -                                             assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
> > -                                                               <&clk IMX8MP_CLK_ML_AXI>,
> > -                                                               <&clk IMX8MP_CLK_ML_AHB>;
> > -                                             assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
> > -                                                                      <&clk IMX8MP_SYS_PLL1_800M>,
> > -                                                                      <&clk IMX8MP_SYS_PLL1_800M>;
> > -                                             assigned-clock-rates = <800000000>,
> > -                                                                    <800000000>,
> > -                                                                    <300000000>;
> > -                                     };
> >                               };
> >                       };
> >               };
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
>
>
Re: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location
Posted by Marek Vasut 1 year, 6 months ago 
On 6/18/24 12:39 AM, Adam Ford wrote:
> The pgc_mlmix shows a power-domain@24, but the reg value is
> IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.
> 
> The stuff after the @ symbol should match the stuff referenced
> by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.
> 
> Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
> Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>

Reviewed-by: Marek Vasut <marex@denx.de>

Thanks !

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.