nvme: fix NVME_NS_DEAC may incorrectly identifying the disk as EXT_LBA.

[PATCH] nvme: fix NVME_NS_DEAC may incorrectly identifying the disk as EXT_LBA.

Posted by Boyang Yu 1 year, 7 months ago

The value of NVME_NS_DEAC is 3,
which means NVME_NS_METADATA_SUPPORTED | NVME_NS_EXT_LBAS.

Signed-off-by: Boyang Yu <yuboyang@dapustor.com>
---
 drivers/nvme/host/nvme.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index f3a41133ac3f..68b400f9c42d 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -502,7 +502,7 @@ static inline bool nvme_ns_head_multipath(struct nvme_ns_head *head)
 enum nvme_ns_features {
 	NVME_NS_EXT_LBAS = 1 << 0, /* support extended LBA format */
 	NVME_NS_METADATA_SUPPORTED = 1 << 1, /* support getting generated md */
-	NVME_NS_DEAC,		/* DEAC bit in Write Zeores supported */
+	NVME_NS_DEAC = 1 << 2,		/* DEAC bit in Write Zeores supported */
 };
 
 struct nvme_ns {
-- 
2.27.0

Re: [PATCH] nvme: fix NVME_NS_DEAC may incorrectly identifying the disk as EXT_LBA.

Posted by Kanchan Joshi 1 year, 7 months ago

On 6/17/2024 6:41 PM, Boyang Yu wrote:
> The value of NVME_NS_DEAC is 3,
> which means NVME_NS_METADATA_SUPPORTED | NVME_NS_EXT_LBAS.
> 
> Signed-off-by: Boyang Yu<yuboyang@dapustor.com>

Maybe this requires fixes tag [*].
Looks good regardless.

Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>

[*] 1b96f862eccc ("nvme: implement the DEAC bit for the Write Zeroes 
command")

Re: [PATCH] nvme: fix NVME_NS_DEAC may incorrectly identifying the disk as EXT_LBA.

Posted by Keith Busch 1 year, 7 months ago

On Mon, Jun 17, 2024 at 08:00:00PM +0530, Kanchan Joshi wrote:
> On 6/17/2024 6:41 PM, Boyang Yu wrote:
> > The value of NVME_NS_DEAC is 3,
> > which means NVME_NS_METADATA_SUPPORTED | NVME_NS_EXT_LBAS.
> > 
> > Signed-off-by: Boyang Yu<yuboyang@dapustor.com>
> 
> Maybe this requires fixes tag [*].
> Looks good regardless.
> 
> Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
> 
> [*] 1b96f862eccc ("nvme: implement the DEAC bit for the Write Zeroes 
> command")

Yes, added the fixes tag to the change log to help stable-bot. Thanks,
applied to nvme-6.10.