[PATCH v2] clk: qcom: nsscc-qca8k: Fix the MDIO functions undefined issue

Luo Jie posted 1 patch 1 year, 6 months ago
drivers/clk/qcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] clk: qcom: nsscc-qca8k: Fix the MDIO functions undefined issue
Posted by Luo Jie 1 year, 6 months ago
The clock controller driver of QCA8K depends on MDIO_BUS because
of mdio_module_driver used to register the driver.

This patch fixes the following undefined symbols.
ERROR: modpost: "mdio_driver_register"
[drivers/clk/qcom/nsscc-qca8k.ko] undefined!
ERROR: modpost: "mdio_driver_unregister"
[drivers/clk/qcom/nsscc-qca8k.ko] undefined!
ERROR: modpost: "__mdiobus_write"
[drivers/clk/qcom/nsscc-qca8k.ko] undefined!
ERROR: modpost: "__mdiobus_read"
[drivers/clk/qcom/nsscc-qca8k.ko] undefined!

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202406161634.B27sOs8B-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202406162047.QkUMa2fG-lkp@intel.com/
Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
---
Changes in v2:
	*update the depends on MDIO_BUS.
---
 drivers/clk/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 4432b1cce478..1e468e48401b 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -251,7 +251,7 @@ config IPQ_GCC_9574
 
 config IPQ_NSSCC_QCA8K
 	tristate "QCA8K(QCA8386 or QCA8084) NSS Clock Controller"
-	depends on MDIO_BUS || COMPILE_TEST
+	depends on MDIO_BUS
 	help
 	  Support for NSS(Network SubSystem) clock controller on
 	  qca8386/qca8084 chip.
-- 
2.34.1
Re: [PATCH v2] clk: qcom: nsscc-qca8k: Fix the MDIO functions undefined issue
Posted by Bjorn Andersson 1 year, 5 months ago
On Mon, 17 Jun 2024 17:38:06 +0800, Luo Jie wrote:
> The clock controller driver of QCA8K depends on MDIO_BUS because
> of mdio_module_driver used to register the driver.
> 
> This patch fixes the following undefined symbols.
> ERROR: modpost: "mdio_driver_register"
> [drivers/clk/qcom/nsscc-qca8k.ko] undefined!
> ERROR: modpost: "mdio_driver_unregister"
> [drivers/clk/qcom/nsscc-qca8k.ko] undefined!
> ERROR: modpost: "__mdiobus_write"
> [drivers/clk/qcom/nsscc-qca8k.ko] undefined!
> ERROR: modpost: "__mdiobus_read"
> [drivers/clk/qcom/nsscc-qca8k.ko] undefined!
> 
> [...]

Applied, thanks!

[1/1] clk: qcom: nsscc-qca8k: Fix the MDIO functions undefined issue
      commit: b45120fbd39825ca0d32e39309c30a9e9d567cd8

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>