fbdev: amifb: add missing MODULE_DESCRIPTION() macro

[PATCH] fbdev: amifb: add missing MODULE_DESCRIPTION() macro

Posted by Jeff Johnson 1 year, 6 months ago

With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/amifb.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/video/fbdev/amifb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/fbdev/amifb.c b/drivers/video/fbdev/amifb.c
index 305f396c764c..132638240521 100644
--- a/drivers/video/fbdev/amifb.c
+++ b/drivers/video/fbdev/amifb.c
@@ -3782,5 +3782,6 @@ static struct platform_driver amifb_driver __refdata = {
 
 module_platform_driver_probe(amifb_driver, amifb_probe);
 
+MODULE_DESCRIPTION("Amiga builtin chipset frame buffer driver");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:amiga-video");

---
base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
change-id: 20240617-md-m68k-drivers-video-fbdev-amifb-3f65d4a6ed79

Re: [PATCH] fbdev: amifb: add missing MODULE_DESCRIPTION() macro

Posted by Helge Deller 1 year, 6 months ago

On 6/18/24 05:14, Jeff Johnson wrote:
> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/amifb.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

both patches applied.

Thanks!
Helge

> ---
>   drivers/video/fbdev/amifb.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/amifb.c b/drivers/video/fbdev/amifb.c
> index 305f396c764c..132638240521 100644
> --- a/drivers/video/fbdev/amifb.c
> +++ b/drivers/video/fbdev/amifb.c
> @@ -3782,5 +3782,6 @@ static struct platform_driver amifb_driver __refdata = {
>
>   module_platform_driver_probe(amifb_driver, amifb_probe);
>
> +MODULE_DESCRIPTION("Amiga builtin chipset frame buffer driver");
>   MODULE_LICENSE("GPL");
>   MODULE_ALIAS("platform:amiga-video");
>
> ---
> base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
> change-id: 20240617-md-m68k-drivers-video-fbdev-amifb-3f65d4a6ed79
>

Re: [PATCH] fbdev: amifb: add missing MODULE_DESCRIPTION() macro

Posted by Geert Uytterhoeven 1 year, 6 months ago

On Tue, Jun 18, 2024 at 5:14 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/fbdev/amifb.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds