1. Patchew
  2. linux
  3. View series

[PATCH] m68k: add missing MODULE_DESCRIPTION() macros

Jeff Johnson posted 1 patch 1 year, 6 months ago 
arch/m68k/emu/nfblock.c | 1 +
arch/m68k/emu/nfcon.c   | 1 +
2 files changed, 2 insertions(+)
[PATCH] m68k: add missing MODULE_DESCRIPTION() macros
Posted by Jeff Johnson 1 year, 6 months ago 
With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfblock.o
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfcon.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 arch/m68k/emu/nfblock.c | 1 +
 arch/m68k/emu/nfcon.c   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/m68k/emu/nfblock.c b/arch/m68k/emu/nfblock.c
index 642fb80c5c4e..b35ac17e7ea9 100644
--- a/arch/m68k/emu/nfblock.c
+++ b/arch/m68k/emu/nfblock.c
@@ -193,4 +193,5 @@ static void __exit nfhd_exit(void)
 module_init(nfhd_init);
 module_exit(nfhd_exit);
 
+MODULE_DESCRIPTION("ARAnyM block device driver");
 MODULE_LICENSE("GPL");
diff --git a/arch/m68k/emu/nfcon.c b/arch/m68k/emu/nfcon.c
index 17b2987c2bf5..0ab2e4d08871 100644
--- a/arch/m68k/emu/nfcon.c
+++ b/arch/m68k/emu/nfcon.c
@@ -173,4 +173,5 @@ static void __exit nfcon_exit(void)
 module_init(nfcon_init);
 module_exit(nfcon_exit);
 
+MODULE_DESCRIPTION("ARAnyM console driver");
 MODULE_LICENSE("GPL");

---
base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
change-id: 20240617-md-m68k-arch-m68k-2f2ca3c2b0db
Re: [PATCH] m68k: add missing MODULE_DESCRIPTION() macros
Posted by Geert Uytterhoeven 1 year, 6 months ago 
Hi Jeff,

On Tue, Jun 18, 2024 at 1:47 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfblock.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfcon.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Thanks for your patch!

> --- a/arch/m68k/emu/nfblock.c
> +++ b/arch/m68k/emu/nfblock.c
> @@ -193,4 +193,5 @@ static void __exit nfhd_exit(void)
>  module_init(nfhd_init);
>  module_exit(nfhd_exit);
>
> +MODULE_DESCRIPTION("ARAnyM block device driver");

I think that should be s/ARAnyM/Atari NatFeat/, as I believe NatFeat
is also available on other Atari emulators. See also nfeth.c

>  MODULE_LICENSE("GPL");
> diff --git a/arch/m68k/emu/nfcon.c b/arch/m68k/emu/nfcon.c
> index 17b2987c2bf5..0ab2e4d08871 100644
> --- a/arch/m68k/emu/nfcon.c
> +++ b/arch/m68k/emu/nfcon.c
> @@ -173,4 +173,5 @@ static void __exit nfcon_exit(void)
>  module_init(nfcon_init);
>  module_exit(nfcon_exit);
>
> +MODULE_DESCRIPTION("ARAnyM console driver");

Likewise.

>  MODULE_LICENSE("GPL");

If you agree, I can make these changes while queuing in the m68k tree
for v6.11.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH] m68k: add missing MODULE_DESCRIPTION() macros
Posted by Jeff Johnson 1 year, 6 months ago 
On 6/18/2024 12:36 AM, Geert Uytterhoeven wrote:
> Hi Jeff,
> 
> On Tue, Jun 18, 2024 at 1:47 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfblock.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfcon.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> 
> Thanks for your patch!
> 
>> --- a/arch/m68k/emu/nfblock.c
>> +++ b/arch/m68k/emu/nfblock.c
>> @@ -193,4 +193,5 @@ static void __exit nfhd_exit(void)
>>  module_init(nfhd_init);
>>  module_exit(nfhd_exit);
>>
>> +MODULE_DESCRIPTION("ARAnyM block device driver");
> 
> I think that should be s/ARAnyM/Atari NatFeat/, as I believe NatFeat
> is also available on other Atari emulators. See also nfeth.c
> 
>>  MODULE_LICENSE("GPL");
>> diff --git a/arch/m68k/emu/nfcon.c b/arch/m68k/emu/nfcon.c
>> index 17b2987c2bf5..0ab2e4d08871 100644
>> --- a/arch/m68k/emu/nfcon.c
>> +++ b/arch/m68k/emu/nfcon.c
>> @@ -173,4 +173,5 @@ static void __exit nfcon_exit(void)
>>  module_init(nfcon_init);
>>  module_exit(nfcon_exit);
>>
>> +MODULE_DESCRIPTION("ARAnyM console driver");
> 
> Likewise.
> 
>>  MODULE_LICENSE("GPL");
> 
> If you agree, I can make these changes while queuing in the m68k tree
> for v6.11.

You are the domain expert here. I'd be very happy for you to make the changes :)

/jeff
Re: [PATCH] m68k: add missing MODULE_DESCRIPTION() macros
Posted by Geert Uytterhoeven 1 year, 5 months ago 
Hi Jeff,

On Tue, Jun 18, 2024 at 4:46 PM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> On 6/18/2024 12:36 AM, Geert Uytterhoeven wrote:
> > On Tue, Jun 18, 2024 at 1:47 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> >> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfblock.o
> >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfcon.o
> >>
> >> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> >>
> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> >
> > Thanks for your patch!
> >
> >> --- a/arch/m68k/emu/nfblock.c
> >> +++ b/arch/m68k/emu/nfblock.c
> >> @@ -193,4 +193,5 @@ static void __exit nfhd_exit(void)
> >>  module_init(nfhd_init);
> >>  module_exit(nfhd_exit);
> >>
> >> +MODULE_DESCRIPTION("ARAnyM block device driver");
> >
> > I think that should be s/ARAnyM/Atari NatFeat/, as I believe NatFeat
> > is also available on other Atari emulators. See also nfeth.c
> >
> >>  MODULE_LICENSE("GPL");
> >> diff --git a/arch/m68k/emu/nfcon.c b/arch/m68k/emu/nfcon.c
> >> index 17b2987c2bf5..0ab2e4d08871 100644
> >> --- a/arch/m68k/emu/nfcon.c
> >> +++ b/arch/m68k/emu/nfcon.c
> >> @@ -173,4 +173,5 @@ static void __exit nfcon_exit(void)
> >>  module_init(nfcon_init);
> >>  module_exit(nfcon_exit);
> >>
> >> +MODULE_DESCRIPTION("ARAnyM console driver");
> >
> > Likewise.
> >
> >>  MODULE_LICENSE("GPL");
> >
> > If you agree, I can make these changes while queuing in the m68k tree
> > for v6.11.
>
> You are the domain expert here. I'd be very happy for you to make the changes :)

I made these changes while applying your patch. No need to resend.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.