arm64: dts: exynos: gs101-oriole: add regulators for USB phy

[PATCH] arm64: dts: exynos: gs101-oriole: add regulators for USB phy

Posted by André Draszik 1 year, 6 months ago

The USB phy requires various power supplies to work.

While we don't have a PMIC driver yet, they should still be added to
the DT. Do so.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
Note that this patch depends on the updated DT binding from
https://lore.kernel.org/r/20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org
---
 arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
index 5e8ffe065081..1a79d9ab3be0 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
+++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
@@ -145,6 +145,13 @@ &usbdrd31_dwc3 {
 };
 
 &usbdrd31_phy {
+	/* TODO: Update these once PMIC is implemented */
+	pll-supply = <0>;
+	dvdd-usb20-supply = <0>;
+	vddh-usb20-supply = <0>;
+	vdd33-usb20-supply = <0>;
+	vdda-usbdp-supply = <0>;
+	vddh-usbdp-supply = <0>;
 	status = "okay";
 };
 

---
base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0
change-id: 20240617-gs101-usb-regulators-in-dt-bdbbcea25fe9

Best regards,
-- 
André Draszik <andre.draszik@linaro.org>

Re: [PATCH] arm64: dts: exynos: gs101-oriole: add regulators for USB phy

Posted by Krzysztof Kozlowski 1 year, 6 months ago

On 17/06/2024 18:52, André Draszik wrote:
> The USB phy requires various power supplies to work.
> 
> While we don't have a PMIC driver yet, they should still be added to
> the DT. Do so.
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> Note that this patch depends on the updated DT binding from
> https://lore.kernel.org/r/20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org
> ---
>  arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> index 5e8ffe065081..1a79d9ab3be0 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> @@ -145,6 +145,13 @@ &usbdrd31_dwc3 {
>  };
>  
>  &usbdrd31_phy {
> +	/* TODO: Update these once PMIC is implemented */

Rather provide fixed regulators with such remark that they substitute
missing PMIC.

Best regards,
Krzysztof