[PATCH] s390/lcs: add missing MODULE_DESCRIPTION() macro

Jeff Johnson posted 1 patch 1 year, 6 months ago
There is a newer version of this series
drivers/s390/net/lcs.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] s390/lcs: add missing MODULE_DESCRIPTION() macro
Posted by Jeff Johnson 1 year, 6 months ago
With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/net/lcs.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/s390/net/lcs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
index 25d4e6376591..83807ce823e9 100644
--- a/drivers/s390/net/lcs.c
+++ b/drivers/s390/net/lcs.c
@@ -2380,5 +2380,6 @@ module_init(lcs_init_module);
 module_exit(lcs_cleanup_module);
 
 MODULE_AUTHOR("Frank Pavlic <fpavlic@de.ibm.com>");
+MODULE_DESCRIPTION("S/390 Lan Channel Station Network Driver");
 MODULE_LICENSE("GPL");
 

---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240615-md-s390-drivers-s390-net-78a9068f1004
Re: [PATCH] s390/lcs: add missing MODULE_DESCRIPTION() macro
Posted by Alexandra Winter 1 year, 6 months ago

On 16.06.24 06:23, Jeff Johnson wrote:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/net/lcs.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/s390/net/lcs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c
> index 25d4e6376591..83807ce823e9 100644
> --- a/drivers/s390/net/lcs.c
> +++ b/drivers/s390/net/lcs.c
> @@ -2380,5 +2380,6 @@ module_init(lcs_init_module);
>  module_exit(lcs_cleanup_module);
>  
>  MODULE_AUTHOR("Frank Pavlic <fpavlic@de.ibm.com>");
> +MODULE_DESCRIPTION("S/390 Lan Channel Station Network Driver");
>  MODULE_LICENSE("GPL");
>  
> 
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240615-md-s390-drivers-s390-net-78a9068f1004
> 
> 


Thank you very much Jeff for noticing this and sending a patch.

I propose to describe the module as
"LAN channel station device driver"
as this is the term and spelling used in the documentation, e.g. here:
https://www.ibm.com/docs/en/linux-on-systems?topic=n-lcs-device-driver-4

Please send a v2