[PATCH] s390/3270: add missing MODULE_DESCRIPTION() macros

Jeff Johnson posted 1 patch 1 year, 6 months ago
drivers/s390/char/con3270.c | 1 +
drivers/s390/char/fs3270.c  | 1 +
drivers/s390/char/raw3270.c | 1 +
3 files changed, 3 insertions(+)
[PATCH] s390/3270: add missing MODULE_DESCRIPTION() macros
Posted by Jeff Johnson 1 year, 6 months ago
With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/raw3270.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/con3270.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/fs3270.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/s390/char/con3270.c | 1 +
 drivers/s390/char/fs3270.c  | 1 +
 drivers/s390/char/raw3270.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/s390/char/con3270.c b/drivers/s390/char/con3270.c
index 251d2a1c3eef..053102d0fcd2 100644
--- a/drivers/s390/char/con3270.c
+++ b/drivers/s390/char/con3270.c
@@ -2185,6 +2185,7 @@ con3270_init(void)
 console_initcall(con3270_init);
 #endif
 
+MODULE_DESCRIPTION("IBM/3270 Driver - tty functions");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_CHARDEV_MAJOR(IBM_TTY3270_MAJOR);
 
diff --git a/drivers/s390/char/fs3270.c b/drivers/s390/char/fs3270.c
index 4d824f86bbbb..61515781c5dd 100644
--- a/drivers/s390/char/fs3270.c
+++ b/drivers/s390/char/fs3270.c
@@ -559,6 +559,7 @@ static void __exit fs3270_exit(void)
 	__unregister_chrdev(IBM_FS3270_MAJOR, 0, 1, "fs3270");
 }
 
+MODULE_DESCRIPTION("IBM/3270 Driver - fullscreen driver");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_CHARDEV_MAJOR(IBM_FS3270_MAJOR);
 
diff --git a/drivers/s390/char/raw3270.c b/drivers/s390/char/raw3270.c
index c57694be9bd3..ba3d7114b34f 100644
--- a/drivers/s390/char/raw3270.c
+++ b/drivers/s390/char/raw3270.c
@@ -1341,6 +1341,7 @@ static void raw3270_exit(void)
 	class_unregister(&class3270);
 }
 
+MODULE_DESCRIPTION("IBM/3270 Driver - core functions");
 MODULE_LICENSE("GPL");
 
 module_init(raw3270_init);

---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240615-md-s390-drivers-s390-char-94fad7b2de6d
Re: [PATCH] s390/3270: add missing MODULE_DESCRIPTION() macros
Posted by Vasily Gorbik 1 year, 5 months ago
On Sat, Jun 15, 2024 at 08:01:17PM -0700, Jeff Johnson wrote:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/raw3270.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/con3270.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/char/fs3270.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/s390/char/con3270.c | 1 +
>  drivers/s390/char/fs3270.c  | 1 +
>  drivers/s390/char/raw3270.c | 1 +
>  3 files changed, 3 insertions(+)

Applied, thanks!