[PATCH v3 00/38] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl

James Morse posted 38 patches 1 year, 6 months ago
There is a newer version of this series
MAINTAINERS                               |   2 +
arch/Kconfig                              |   8 +
arch/x86/Kconfig                          |  12 +-
arch/x86/include/asm/resctrl.h            |  45 +-
arch/x86/kernel/cpu/resctrl/Makefile      |   5 +-
arch/x86/kernel/cpu/resctrl/core.c        | 158 ++---
arch/x86/kernel/cpu/resctrl/ctrlmondata.c |  67 +-
arch/x86/kernel/cpu/resctrl/internal.h    | 185 ++----
arch/x86/kernel/cpu/resctrl/monitor.c     |  88 +--
arch/x86/kernel/cpu/resctrl/pseudo_lock.c |  65 +-
arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 288 +++++---
arch/x86/kernel/process_32.c              |   2 +-
arch/x86/kernel/process_64.c              |   2 +-
fs/Kconfig                                |   1 +
fs/Makefile                               |   1 +
fs/resctrl/Kconfig                        |  36 +
fs/resctrl/Makefile                       |   3 +
fs/resctrl/ctrlmondata.c                  |   0
fs/resctrl/internal.h                     |   0
fs/resctrl/monitor.c                      |   0
fs/resctrl/pseudo_lock.c                  |   0
fs/resctrl/rdtgroup.c                     |   0
fs/resctrl/trace.h                        |   0
include/linux/resctrl.h                   | 193 +++++-
include/linux/resctrl_types.h             |  59 ++
resctrl_copy_pasta.py                     | 766 ++++++++++++++++++++++
26 files changed, 1546 insertions(+), 440 deletions(-)
create mode 100644 fs/resctrl/Kconfig
create mode 100644 fs/resctrl/Makefile
create mode 100644 fs/resctrl/ctrlmondata.c
create mode 100644 fs/resctrl/internal.h
create mode 100644 fs/resctrl/monitor.c
create mode 100644 fs/resctrl/pseudo_lock.c
create mode 100644 fs/resctrl/rdtgroup.c
create mode 100644 fs/resctrl/trace.h
create mode 100644 include/linux/resctrl_types.h
create mode 100644 resctrl_copy_pasta.py
[PATCH v3 00/38] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl
Posted by James Morse 1 year, 6 months ago
Changes since v2?
Patches 3+13 have been merged, then split into six patches that also bring
the format string and a few other parameters into the struct resctrl_schema.
This makes for a cleaner arch/fs split.

Dave's checkpatch fixes to existing code have been broken out into a separate
series to be posted shortly. The asm->linux changes got merged into the patch that
makes this possible.

~

This is the final series that allows other architectures to implement resctrl.
The final patch to move the code has been ommited, but can be generated using
the python script at the end of the series.
The final move is a bit of a monster. I don't expect that to get merged as part
of this series - we should wait for it to make less impact on other series.

Otherwise this series renames functions and moves code around. With the
exception of invalid configurations for the configurable-events, there should
be no changes in behaviour caused by this series.

The driving pattern is to make things like struct rdtgroup private to resctrl.
Features like pseudo-lock aren't going to work on arm64, the ability to disable
it at compile time is added.

After this, I can start posting the MPAM driver to make use of resctrl on arm64.
(What's MPAM? See the cover letter of the first series. [1])

This series is based on v6.10-rc1 and can be retrieved from:
https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/move_to_fs/v3

As ever - bugs welcome,
Thanks,

James

[v2] https://lore.kernel.org/r/20240426150537.8094-1-Dave.Martin@arm.com
[v1] https://lore.kernel.org/r/20240321165106.31602-1-james.morse@arm.com
[1] https://lore.kernel.org/lkml/20201030161120.227225-1-james.morse@arm.com/

James Morse (38):
  x86/resctrl: Fix allocation of cleanest CLOSID on platforms with no
    monitors
  x86/resctrl: Add a helper to avoid reaching into the arch code
    resource list
  x86/resctrl: Add a schema format enum and use this for fflags
  x86/resctrl: Use schema type to determine how to parse schema values
  x86/resctrl: Use schema type to determine the schema format string
  x86/resctrl: Move data_width to be a schema property
  x86/resctrl: Add max_bw to struct resctrl_membw
  x86/resctrl: Generate default_ctrl instead of sharing it
  x86/resctrl: Add helper for setting CPU default properties
  x86/resctrl: Remove rdtgroup from update_cpu_closid_rmid()
  x86/resctrl: Export resctrl fs's init function
  x86/resctrl: Wrap resctrl_arch_find_domain() around rdt_find_domain()
  x86/resctrl: Move resctrl types to a separate header
  x86/resctrl: Add a resctrl helper to reset all the resources
  x86/resctrl: Move monitor exit work to a restrl exit call
  x86/resctrl: Move monitor init work to a resctrl init call
  x86/resctrl: Stop using the for_each_*_rdt_resource() walkers
  x86/resctrl: Export the is_mbm_*_enabled() helpers to asm/resctrl.h
  x86/resctrl: Add resctrl_arch_is_evt_configurable() to abstract BMEC
  x86/resctrl: Change mon_event_config_{read,write}() to be arch helpers
  x86/resctrl: Move mbm_cfg_mask to struct rdt_resource
  x86/resctrl: Add resctrl_arch_ prefix to pseudo lock functions
  x86/resctrl: Allow an architecture to disable pseudo lock
  x86/resctrl: Make prefetch_disable_bits belong to the arch code
  x86/resctrl: Make resctrl_arch_pseudo_lock_fn() take a plr
  x86/resctrl: Move thread_throttle_mode_init() to be managed by resctrl
  x86/resctrl: Move get_config_index() to a header
  x86/resctrl: Claim get_domain_from_cpu() for resctrl
  x86/resctrl: Describe resctrl's bitmap size assumptions
  x86/resctrl: Rename resctrl_sched_in() to begin with "resctrl_arch_"
  x86/resctrl: resctrl_exit() teardown resctrl but leave the mount point
  x86/resctrl: Drop __init/__exit on assorted symbols
  x86/resctrl: Move is_mba_sc() out of core.c
  x86/resctrl: Add end-marker to the resctrl_event_id enum
  x86/resctrl: Remove a newline to avoid confusing the code move script
  fs/resctrl: Add boiler plate for external resctrl code
  x86/resctrl: Move the filesystem bits to headers visible to fs/resctrl
  x86/resctrl: Add python script to move resctrl code to /fs/resctrl

 MAINTAINERS                               |   2 +
 arch/Kconfig                              |   8 +
 arch/x86/Kconfig                          |  12 +-
 arch/x86/include/asm/resctrl.h            |  45 +-
 arch/x86/kernel/cpu/resctrl/Makefile      |   5 +-
 arch/x86/kernel/cpu/resctrl/core.c        | 158 ++---
 arch/x86/kernel/cpu/resctrl/ctrlmondata.c |  67 +-
 arch/x86/kernel/cpu/resctrl/internal.h    | 185 ++----
 arch/x86/kernel/cpu/resctrl/monitor.c     |  88 +--
 arch/x86/kernel/cpu/resctrl/pseudo_lock.c |  65 +-
 arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 288 +++++---
 arch/x86/kernel/process_32.c              |   2 +-
 arch/x86/kernel/process_64.c              |   2 +-
 fs/Kconfig                                |   1 +
 fs/Makefile                               |   1 +
 fs/resctrl/Kconfig                        |  36 +
 fs/resctrl/Makefile                       |   3 +
 fs/resctrl/ctrlmondata.c                  |   0
 fs/resctrl/internal.h                     |   0
 fs/resctrl/monitor.c                      |   0
 fs/resctrl/pseudo_lock.c                  |   0
 fs/resctrl/rdtgroup.c                     |   0
 fs/resctrl/trace.h                        |   0
 include/linux/resctrl.h                   | 193 +++++-
 include/linux/resctrl_types.h             |  59 ++
 resctrl_copy_pasta.py                     | 766 ++++++++++++++++++++++
 26 files changed, 1546 insertions(+), 440 deletions(-)
 create mode 100644 fs/resctrl/Kconfig
 create mode 100644 fs/resctrl/Makefile
 create mode 100644 fs/resctrl/ctrlmondata.c
 create mode 100644 fs/resctrl/internal.h
 create mode 100644 fs/resctrl/monitor.c
 create mode 100644 fs/resctrl/pseudo_lock.c
 create mode 100644 fs/resctrl/rdtgroup.c
 create mode 100644 fs/resctrl/trace.h
 create mode 100644 include/linux/resctrl_types.h
 create mode 100644 resctrl_copy_pasta.py

-- 
2.39.2
Re: [PATCH v3 00/38] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl
Posted by Carl Worth 1 year, 5 months ago
James Morse <james.morse@arm.com> writes:
> This is the final series that allows other architectures to implement resctrl.
> The final patch to move the code has been ommited, but can be generated using
> the python script at the end of the series.
> The final move is a bit of a monster. I don't expect that to get merged as part
> of this series - we should wait for it to make less impact on other
> series.

Thanks, again, James.

As with previous versions, I've tested this code (along with additional
MPAM code from you and other code we've written), to test MPAM
functionality on an Ampere implementation.

I replied to the in the series which introduces
CONFIG_RESCTRL_FS_PSEUDO_LOCK to point out how that commit will actually
break compilation if that option is not selected, (and I described the
minor change needed to fix that).

With that fixed, for the series:

Tested-by: Carl Worth <carl@os.amperecomputing.com> # arm64

-Carl
Re: [PATCH v3 00/38] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl
Posted by James Morse 1 year, 4 months ago
Hi Carl,

On 11/07/2024 23:00, Carl Worth wrote:
> James Morse <james.morse@arm.com> writes:
>> This is the final series that allows other architectures to implement resctrl.
>> The final patch to move the code has been ommited, but can be generated using
>> the python script at the end of the series.
>> The final move is a bit of a monster. I don't expect that to get merged as part
>> of this series - we should wait for it to make less impact on other
>> series.
> 
> Thanks, again, James.
> 
> As with previous versions, I've tested this code (along with additional
> MPAM code from you and other code we've written), to test MPAM
> functionality on an Ampere implementation.
> 
> I replied to the in the series which introduces
> CONFIG_RESCTRL_FS_PSEUDO_LOCK to point out how that commit will actually
> break compilation if that option is not selected, (and I described the
> minor change needed to fix that).
> 
> With that fixed, for the series:
> 
> Tested-by: Carl Worth <carl@os.amperecomputing.com> # arm64

Great - thanks!
(I assume you didn't test the python script that generates the move-to-fs patch)


Thanks,

James