[v1] dt-bindings: thermal: few cleanups

[PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells

Posted by Krzysztof Kozlowski 3 months, 1 week ago

All Samsung Exynos SoCs Thermal Management Units have only one sensor,
so make '#thermal-sensor-cells' fixed at 0.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
index 1344df708e2d..29a08b0729ee 100644
--- a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
@@ -61,7 +61,8 @@ properties:
           TRIMINFO at 0x10068000 contains data for TMU channel 2
     minItems: 1
 
-  '#thermal-sensor-cells': true
+  '#thermal-sensor-cells':
+    const: 0
 
   vtmu-supply:
     description: The regulator node supplying voltage to TMU.

-- 
2.43.0

RE: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells

Posted by Alim Akhtar 3 months, 1 week ago

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, June 14, 2024 3:16 PM
> To: Daniel Lezcano <daniel.lezcano@linaro.org
.stormreply.com;
> Subject: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells
> 
> All Samsung Exynos SoCs Thermal Management Units have only one sensor, so
> make '#thermal-sensor-cells' fixed at 0.
> 
This is not entirely true, there are SoCs which have multiple temp sensors.
It is true that currently only one sensor support is added though.

So we can leave this as is or you suggest to make it to support only one sensor
(to match the current DT support), and later (in near future) change it again to
match what HW actually support?

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml | 3
> ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml
> index 1344df708e2d..29a08b0729ee 100644
> --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.y
> +++ aml
> @@ -61,7 +61,8 @@ properties:
>            TRIMINFO at 0x10068000 contains data for TMU channel 2
>      minItems: 1
> 
> -  '#thermal-sensor-cells': true
> +  '#thermal-sensor-cells':
> +    const: 0
> 
>    vtmu-supply:
>      description: The regulator node supplying voltage to TMU.
> 
> --
> 2.43.0

Re: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells

Posted by Krzysztof Kozlowski 3 months ago

On 14/06/2024 16:29, Alim Akhtar wrote:
> Hi Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Friday, June 14, 2024 3:16 PM
>> To: Daniel Lezcano <daniel.lezcano@linaro.org
> .stormreply.com;
>> Subject: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells
>>
>> All Samsung Exynos SoCs Thermal Management Units have only one sensor, so
>> make '#thermal-sensor-cells' fixed at 0.
>>
> This is not entirely true, there are SoCs which have multiple temp sensors.
> It is true that currently only one sensor support is added though.

All supported by mainline. Others do not exist now :)

> 
> So we can leave this as is or you suggest to make it to support only one sensor
> (to match the current DT support), and later (in near future) change it again to
> match what HW actually support?

Yes, different devices can have different value (and bindings).
Best regards,
Krzysztof

RE: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells

Posted by Alim Akhtar 2 months, 3 weeks ago


> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Saturday, June 15, 2024 3:09 PM
> To: Alim Akhtar <alim.akhtar@samsung.com>; 'Krzysztof Kozlowski'
> <krzysztof.kozlowski@linaro.org>; 'Daniel Lezcano'
[snip]
> On 14/06/2024 16:29, Alim Akhtar wrote:
> > Hi Krzysztof,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: Friday, June 14, 2024 3:16 PM
> >> To: Daniel Lezcano <daniel.lezcano@linaro.org
> > .stormreply.com;
> >> Subject: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify
> >> cells
> >>
> >> All Samsung Exynos SoCs Thermal Management Units have only one
> >> sensor, so make '#thermal-sensor-cells' fixed at 0.
> >>
> > This is not entirely true, there are SoCs which have multiple temp sensors.
> > It is true that currently only one sensor support is added though.
> 
> All supported by mainline. Others do not exist now :)
> 
> >
> > So we can leave this as is or you suggest to make it to support only
> > one sensor (to match the current DT support), and later (in near
> > future) change it again to match what HW actually support?
> 
> Yes, different devices can have different value (and bindings).
Ok, this is fine for now.

> Best regards,
> Krzysztof