[PATCH 0/8] firewire: store the numeric identifier of card in data structure for tracepoint events

Takashi Sakamoto posted 8 patches 1 year, 8 months ago
drivers/firewire/core-card.c        |   6 +-
drivers/firewire/core-cdev.c        |   6 +-
drivers/firewire/core-topology.c    |   2 +-
drivers/firewire/core-transaction.c |  30 ++++----
include/trace/events/firewire.h     | 113 +++++++++++++++++-----------
5 files changed, 92 insertions(+), 65 deletions(-)
[PATCH 0/8] firewire: store the numeric identifier of card in data structure for tracepoint events
Posted by Takashi Sakamoto 1 year, 8 months ago
Hi,

In v6.10 kernel, some tracepoints events are added to record
IEEE 1394 asynchronous communication. In the case that multiple 1394 OHCI
controllers are available in Linux system, it is hard to distinguish
the controller used for the communication, since these events have no
member in their data structure to express the used controller. It is a
bit inconvenient to diagnose things.

This series of patches is an attempt to solve the issue. In Linux
FireWire core, the available controllers are maintained in list, and
each of them has its own numeric identifier (=card_index). In this
series, the index value is added to the data structure.

I would like to put the change to v6.10-rc4 (or later) as the part of
fixes if receiving no objections.

Takashi Sakamoto (8):
  firewire: core: record card index in tracepoinrts events derived from
    async_outbound_complete_template
  firewire: core: record card index in tracepoinrts events derived from
    async_outbound_initiate_template
  firewire: core: record card index in tracepoinrts events derived from
    async_inbound_template
  firewire: core: record card index in async_phy_outbound_initiate
    tracepoints event
  firewire: core: record card index in async_phy_outbound_complete
    tracepoints event
  firewire: core: record card index in async_phy_inbound tracepoints
    event
  firewire: core: record card index in tracepoinrts events derived from
    bus_reset_arrange_template
  firewire: core: record card index in bus_reset_handle tracepoints
    event

 drivers/firewire/core-card.c        |   6 +-
 drivers/firewire/core-cdev.c        |   6 +-
 drivers/firewire/core-topology.c    |   2 +-
 drivers/firewire/core-transaction.c |  30 ++++----
 include/trace/events/firewire.h     | 113 +++++++++++++++++-----------
 5 files changed, 92 insertions(+), 65 deletions(-)

-- 
2.43.0
Re: [PATCH 0/8] firewire: store the numeric identifier of card in data structure for tracepoint events
Posted by Takashi Sakamoto 1 year, 8 months ago
On Thu, Jun 13, 2024 at 10:14:32PM +0900, Takashi Sakamoto wrote:
> Hi,
> 
> In v6.10 kernel, some tracepoints events are added to record
> IEEE 1394 asynchronous communication. In the case that multiple 1394 OHCI
> controllers are available in Linux system, it is hard to distinguish
> the controller used for the communication, since these events have no
> member in their data structure to express the used controller. It is a
> bit inconvenient to diagnose things.
> 
> This series of patches is an attempt to solve the issue. In Linux
> FireWire core, the available controllers are maintained in list, and
> each of them has its own numeric identifier (=card_index). In this
> series, the index value is added to the data structure.
> 
> I would like to put the change to v6.10-rc4 (or later) as the part of
> fixes if receiving no objections.
> 
> Takashi Sakamoto (8):
>   firewire: core: record card index in tracepoinrts events derived from
>     async_outbound_complete_template
>   firewire: core: record card index in tracepoinrts events derived from
>     async_outbound_initiate_template
>   firewire: core: record card index in tracepoinrts events derived from
>     async_inbound_template
>   firewire: core: record card index in async_phy_outbound_initiate
>     tracepoints event
>   firewire: core: record card index in async_phy_outbound_complete
>     tracepoints event
>   firewire: core: record card index in async_phy_inbound tracepoints
>     event
>   firewire: core: record card index in tracepoinrts events derived from
>     bus_reset_arrange_template
>   firewire: core: record card index in bus_reset_handle tracepoints
>     event
> 
>  drivers/firewire/core-card.c        |   6 +-
>  drivers/firewire/core-cdev.c        |   6 +-
>  drivers/firewire/core-topology.c    |   2 +-
>  drivers/firewire/core-transaction.c |  30 ++++----
>  include/trace/events/firewire.h     | 113 +++++++++++++++++-----------
>  5 files changed, 92 insertions(+), 65 deletions(-)

Applied to for-linus branch.


Thanks

Takashi Sakamoto