QDU1000 DTSI comes with one LLCC0-7 base addresses. Updating
dt-bindings accordingly.

Fixes: f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")
Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
---
 Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
index 192911696010..68ea5f70b75f 100644
--- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
+++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
@@ -67,7 +67,6 @@ allOf:
         compatible:
           contains:
             enum:
-              - qcom,qdu1000-llcc
               - qcom,sc7180-llcc
               - qcom,sm6350-llcc
     then:
@@ -132,6 +131,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,qdu1000-llcc
               - qcom,sc8180x-llcc
               - qcom,sc8280xp-llcc
               - qcom,x1e80100-llcc
--
2.42.0

On 12/06/2024 08:27, Komal Bajaj wrote:
> QDU1000 DTSI comes with one LLCC0-7 base addresses. Updating
> dt-bindings accordingly.
> 
> Fixes: f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")

You are basically reverting without saying this is a revert and without
explanation.

What's happening with QDU1000? Why it is such a mess that DTS was
totally not matching bindings drivers and now suddenly we need to revert
commits?

Best regards,
Krzysztof

On Wed, Jun 12, 2024 at 09:58:50AM +0200, Krzysztof Kozlowski wrote:
> On 12/06/2024 08:27, Komal Bajaj wrote:
> > QDU1000 DTSI comes with one LLCC0-7 base addresses. Updating
> > dt-bindings accordingly.
> > 
> > Fixes: f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")
> 
> You are basically reverting without saying this is a revert and without
> explanation.
> 
> What's happening with QDU1000? Why it is such a mess that DTS was
> totally not matching bindings drivers and now suddenly we need to revert
> commits?

I think, this happened because of the refactoring happened in LLCC driver
and at the same time QDU1000 device tree change picked while other SoCs
change was made like 

e.g
https://lore.kernel.org/r/20230314080443.64635-11-manivannan.sadhasivam@linaro.org
https://lore.kernel.org/r/20230517-topic-kailua-llcc-v1-2-d57bd860c43e@linaro.org


However, this change missed for QDU1000, later f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries")
happened and now realized the driver does not work anymore with current
binding and hence fixing was required.

-Mukesh