[v5] net: dsa: lantiq_gswip: code improvements

[PATCH net-next v5 12/12] net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb()

Posted by Martin Schiller 1 year, 6 months ago

From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Print that no FID is found for bridge %s instead of the incorrect
message that the port is not part of a bridge.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 drivers/net/dsa/lantiq_gswip.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index ec52c62eadce..fcd4505f4925 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -1370,7 +1370,8 @@ static int gswip_port_fdb(struct dsa_switch *ds, int port,
 	}
 
 	if (fid == -1) {
-		dev_err(priv->dev, "Port not part of a bridge\n");
+		dev_err(priv->dev, "no FID found for bridge %s\n",
+			bridge->name);
 		return -EINVAL;
 	}
 
-- 
2.39.2

Re: [PATCH net-next v5 12/12] net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb()

Posted by Vladimir Oltean 1 year, 6 months ago

On Tue, Jun 11, 2024 at 03:54:34PM +0200, Martin Schiller wrote:
> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> Print that no FID is found for bridge %s instead of the incorrect
> message that the port is not part of a bridge.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---

This needs your Signed-off-by tag as well. Anyway, if there is no other
reason to resend, maybe you can post it here as a reply and the
maintainers can pick it up while applying.

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

Re: [PATCH net-next v5 12/12] net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb()

Posted by Martin Schiller 1 year, 6 months ago

On 2024-06-13 13:48, Vladimir Oltean wrote:
> On Tue, Jun 11, 2024 at 03:54:34PM +0200, Martin Schiller wrote:
>> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> 
>> Print that no FID is found for bridge %s instead of the incorrect
>> message that the port is not part of a bridge.
>> 
>> Signed-off-by: Martin Blumenstingl 
>> <martin.blumenstingl@googlemail.com>
>> Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
>> ---
> 
> This needs your Signed-off-by tag as well. Anyway, if there is no other
> reason to resend, maybe you can post it here as a reply and the
> maintainers can pick it up while applying.
> 
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

Thank you for pointing this out to me.

Signed-off-by: Martin Schiller <ms@dev.tdt.de>