[PATCH v2 4/4] bcachefs: remove now spurious i_state initialization

Mateusz Guzik posted 4 patches 1 year, 8 months ago
[PATCH v2 4/4] bcachefs: remove now spurious i_state initialization
Posted by Mateusz Guzik 1 year, 8 months ago
inode_init_always started setting the field to 0.

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
 fs/bcachefs/fs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c
index 514bf83ebe29..f9044da417ac 100644
--- a/fs/bcachefs/fs.c
+++ b/fs/bcachefs/fs.c
@@ -230,7 +230,6 @@ static struct bch_inode_info *__bch2_new_inode(struct bch_fs *c)
 	two_state_lock_init(&inode->ei_pagecache_lock);
 	INIT_LIST_HEAD(&inode->ei_vfs_inode_list);
 	mutex_init(&inode->ei_quota_lock);
-	inode->v.i_state = 0;
 
 	if (unlikely(inode_init_always(c->vfs_sb, &inode->v))) {
 		kmem_cache_free(bch2_inode_cache, inode);
-- 
2.43.0
Re: [PATCH v2 4/4] bcachefs: remove now spurious i_state initialization
Posted by Kent Overstreet 1 year, 8 months ago
On Tue, Jun 11, 2024 at 02:06:26PM GMT, Mateusz Guzik wrote:
> inode_init_always started setting the field to 0.
> 
> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>

Acked-by: Kent Overstreet <kent.overstreet@linux.dev>