[PATCH v2 2/2] signal.7: Fix wrong mention of sigprocmask

Dev Jain posted 2 patches 1 year, 6 months ago
[PATCH v2 2/2] signal.7: Fix wrong mention of sigprocmask
Posted by Dev Jain 1 year, 6 months ago
The handler is registered with sigaction(), not sigprocmask(). Even if the
purpose of writing sigprocmask() here was to mention blocked signals, the
statement currently concerns the "addition" of blocked signals; signals
blocked through sigprocmask() would already be present in the thread
context of blocked signals.

Fixes: e7a5700 (getcontext.3, signal.7: tfix)
Signed-off-by: Dev Jain <dev.jain@arm.com>
---
 man/man7/signal.7 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/man7/signal.7 b/man/man7/signal.7
index 7d22a7cfe..57eab7847 100644
--- a/man/man7/signal.7
+++ b/man/man7/signal.7
@@ -293,7 +293,7 @@ contain the mask of new signals blocked through
 Any signals specified in
 .I act\->sa_mask
 when registering the handler with
-.BR sigprocmask (2)
+.BR sigaction (2)
 are added to the thread's signal mask.
 The signal being delivered is also
 added to the signal mask, unless
-- 
2.34.1
Re: [PATCH v2 2/2] signal.7: Fix wrong mention of sigprocmask
Posted by Mark Brown 1 year, 6 months ago
On Tue, Jun 11, 2024 at 02:38:23PM +0530, Dev Jain wrote:
> The handler is registered with sigaction(), not sigprocmask(). Even if the
> purpose of writing sigprocmask() here was to mention blocked signals, the
> statement currently concerns the "addition" of blocked signals; signals
> blocked through sigprocmask() would already be present in the thread
> context of blocked signals.

Reviewed-by: Mark Brown <broonie@kernel.org>
Re: [PATCH v2 2/2] signal.7: Fix wrong mention of sigprocmask
Posted by Alejandro Colomar 1 year, 6 months ago
Hi Dev, Mark,

On Tue, Jun 11, 2024 at 02:06:31PM GMT, Mark Brown wrote:
> On Tue, Jun 11, 2024 at 02:38:23PM +0530, Dev Jain wrote:
> > The handler is registered with sigaction(), not sigprocmask(). Even if the
> > purpose of writing sigprocmask() here was to mention blocked signals, the
> > statement currently concerns the "addition" of blocked signals; signals
> > blocked through sigprocmask() would already be present in the thread
> > context of blocked signals.
> 
> Reviewed-by: Mark Brown <broonie@kernel.org>

Thanks for the patch and the review!  I've applied the patch.  It will
be included in the man-pages-6.9.1 release later today.

Have a lovely day!
Alex

-- 
<https://www.alejandro-colomar.es/>