Rename sigaltstack to signal, and rename the existing test to
sigaltstack.c.
Signed-off-by: Dev Jain <dev.jain@arm.com>
---
tools/testing/selftests/Makefile | 2 +-
tools/testing/selftests/{sigaltstack => signal}/.gitignore | 2 +-
tools/testing/selftests/{sigaltstack => signal}/Makefile | 2 +-
.../selftests/{sigaltstack => signal}/current_stack_pointer.h | 0
.../selftests/{sigaltstack/sas.c => signal/sigaltstack.c} | 0
5 files changed, 3 insertions(+), 3 deletions(-)
rename tools/testing/selftests/{sigaltstack => signal}/.gitignore (76%)
rename tools/testing/selftests/{sigaltstack => signal}/Makefile (72%)
rename tools/testing/selftests/{sigaltstack => signal}/current_stack_pointer.h (100%)
rename tools/testing/selftests/{sigaltstack/sas.c => signal/sigaltstack.c} (100%)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 9039f3709aff..eee1031dc18f 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -85,7 +85,7 @@ TARGETS += rtc
TARGETS += rust
TARGETS += seccomp
TARGETS += sgx
-TARGETS += sigaltstack
+TARGETS += signal
TARGETS += size
TARGETS += sparc64
TARGETS += splice
diff --git a/tools/testing/selftests/sigaltstack/.gitignore b/tools/testing/selftests/signal/.gitignore
similarity index 76%
rename from tools/testing/selftests/sigaltstack/.gitignore
rename to tools/testing/selftests/signal/.gitignore
index 50a19a8888ce..98a7bbc4f325 100644
--- a/tools/testing/selftests/sigaltstack/.gitignore
+++ b/tools/testing/selftests/signal/.gitignore
@@ -1,2 +1,2 @@
# SPDX-License-Identifier: GPL-2.0-only
-sas
+sigaltstack
diff --git a/tools/testing/selftests/sigaltstack/Makefile b/tools/testing/selftests/signal/Makefile
similarity index 72%
rename from tools/testing/selftests/sigaltstack/Makefile
rename to tools/testing/selftests/signal/Makefile
index 3e96d5d47036..dd6be992fd81 100644
--- a/tools/testing/selftests/sigaltstack/Makefile
+++ b/tools/testing/selftests/signal/Makefile
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
CFLAGS = -Wall
-TEST_GEN_PROGS = sas
+TEST_GEN_PROGS = sigaltstack
include ../lib.mk
diff --git a/tools/testing/selftests/sigaltstack/current_stack_pointer.h b/tools/testing/selftests/signal/current_stack_pointer.h
similarity index 100%
rename from tools/testing/selftests/sigaltstack/current_stack_pointer.h
rename to tools/testing/selftests/signal/current_stack_pointer.h
diff --git a/tools/testing/selftests/sigaltstack/sas.c b/tools/testing/selftests/signal/sigaltstack.c
similarity index 100%
rename from tools/testing/selftests/sigaltstack/sas.c
rename to tools/testing/selftests/signal/sigaltstack.c
--
2.34.1
On Tue, Jun 11, 2024 at 01:26:49PM +0530, Dev Jain wrote: > Rename sigaltstack to signal, and rename the existing test to > sigaltstack.c. > > Signed-off-by: Dev Jain <dev.jain@arm.com> > --- If people review patches and give a tag for them you should carry the tag forward to avoid having to duplicate the review. From v1: I think this is reasonable if we're going to add more generic signal tests - sigaltstack is a fairly small bit of functionality and having it covered as part of a broader signal suite and the overhead of setting up the suite separately is probably not worth it. Reviewed-by: Mark Brown <broonie@kernel.org>
On 6/11/24 16:24, Mark Brown wrote: > On Tue, Jun 11, 2024 at 01:26:49PM +0530, Dev Jain wrote: >> Rename sigaltstack to signal, and rename the existing test to >> sigaltstack.c. >> >> Signed-off-by: Dev Jain <dev.jain@arm.com> >> --- > If people review patches and give a tag for them you should carry the > tag forward to avoid having to duplicate the review. From v1: > > I think this is reasonable if we're going to add more generic signal > tests - sigaltstack is a fairly small bit of functionality and having it > covered as part of a broader signal suite and the overhead of setting up > the suite separately is probably not worth it. > > Reviewed-by: Mark Brown <broonie@kernel.org> Ah yes, I did know it, I forgot. Shall take care.
© 2016 - 2025 Red Hat, Inc.