riscv: vdso: do not strip debugging info for vdso.so.dbg

[PATCH] riscv: vdso: do not strip debugging info for vdso.so.dbg

Posted by Changbin Du 1 year, 8 months ago

The vdso.so.dbg is a debug version of vdso and could be used for debugging
purpose. For example, perf-annotate requires debugging info to show source
lines. So let's keep its debugging info.

Signed-off-by: Changbin Du <changbin.du@huawei.com>
---
 arch/riscv/kernel/vdso/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile
index f7ef8ad9b550..960feb1526ca 100644
--- a/arch/riscv/kernel/vdso/Makefile
+++ b/arch/riscv/kernel/vdso/Makefile
@@ -45,7 +45,7 @@ $(obj)/vdso.o: $(obj)/vdso.so
 # link rule for the .so file, .lds has to be first
 $(obj)/vdso.so.dbg: $(obj)/vdso.lds $(obj-vdso) FORCE
 	$(call if_changed,vdsold)
-LDFLAGS_vdso.so.dbg = -shared -S -soname=linux-vdso.so.1 \
+LDFLAGS_vdso.so.dbg = -shared -soname=linux-vdso.so.1 \
 	--build-id=sha1 --hash-style=both --eh-frame-hdr
 
 # strip rule for the .so file
-- 
2.34.1

Re: [PATCH] riscv: vdso: do not strip debugging info for vdso.so.dbg

Posted by Alexandre Ghiti 1 year, 7 months ago

Hi Changbin,

On 11/06/2024 06:09, Changbin Du wrote:
> The vdso.so.dbg is a debug version of vdso and could be used for debugging
> purpose. For example, perf-annotate requires debugging info to show source
> lines. So let's keep its debugging info.
>
> Signed-off-by: Changbin Du <changbin.du@huawei.com>
> ---
>   arch/riscv/kernel/vdso/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile
> index f7ef8ad9b550..960feb1526ca 100644
> --- a/arch/riscv/kernel/vdso/Makefile
> +++ b/arch/riscv/kernel/vdso/Makefile
> @@ -45,7 +45,7 @@ $(obj)/vdso.o: $(obj)/vdso.so
>   # link rule for the .so file, .lds has to be first
>   $(obj)/vdso.so.dbg: $(obj)/vdso.lds $(obj-vdso) FORCE
>   	$(call if_changed,vdsold)
> -LDFLAGS_vdso.so.dbg = -shared -S -soname=linux-vdso.so.1 \
> +LDFLAGS_vdso.so.dbg = -shared -soname=linux-vdso.so.1 \
>   	--build-id=sha1 --hash-style=both --eh-frame-hdr
>   
>   # strip rule for the .so file


Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>

Thanks,

Alex

Re: [PATCH] riscv: vdso: do not strip debugging info for vdso.so.dbg

Posted by duchangbin 1 year, 7 months ago

Hello,
Is there any problem with this change? Ping~

On Tue, Jun 11, 2024 at 12:09:47PM +0800, Changbin Du wrote:
> The vdso.so.dbg is a debug version of vdso and could be used for debugging
> purpose. For example, perf-annotate requires debugging info to show source
> lines. So let's keep its debugging info.
> 
> Signed-off-by: Changbin Du <changbin.du@huawei.com>
> ---
>  arch/riscv/kernel/vdso/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile
> index f7ef8ad9b550..960feb1526ca 100644
> --- a/arch/riscv/kernel/vdso/Makefile
> +++ b/arch/riscv/kernel/vdso/Makefile
> @@ -45,7 +45,7 @@ $(obj)/vdso.o: $(obj)/vdso.so
>  # link rule for the .so file, .lds has to be first
>  $(obj)/vdso.so.dbg: $(obj)/vdso.lds $(obj-vdso) FORCE
>  	$(call if_changed,vdsold)
> -LDFLAGS_vdso.so.dbg = -shared -S -soname=linux-vdso.so.1 \
> +LDFLAGS_vdso.so.dbg = -shared -soname=linux-vdso.so.1 \
>  	--build-id=sha1 --hash-style=both --eh-frame-hdr
>  
>  # strip rule for the .so file
> -- 
> 2.34.1
> 

-- 
Cheers,
Changbin Du

Re: [PATCH] riscv: vdso: do not strip debugging info for vdso.so.dbg

Posted by Cyril Bur 1 year, 7 months ago


On 4/7/2024 11:57 am, duchangbin wrote:
> Hello,
> Is there any problem with this change? Ping~
> 
> On Tue, Jun 11, 2024 at 12:09:47PM +0800, Changbin Du wrote:
>> The vdso.so.dbg is a debug version of vdso and could be used for debugging
>> purpose. For example, perf-annotate requires debugging info to show source
>> lines. So let's keep its debugging info.
>>
>> Signed-off-by: Changbin Du <changbin.du@huawei.com>

Looks good to me

Reviewed-by: Cyril Bur <cyrilbur@tenstorrent.com>
>> ---
>>   arch/riscv/kernel/vdso/Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile
>> index f7ef8ad9b550..960feb1526ca 100644
>> --- a/arch/riscv/kernel/vdso/Makefile
>> +++ b/arch/riscv/kernel/vdso/Makefile
>> @@ -45,7 +45,7 @@ $(obj)/vdso.o: $(obj)/vdso.so
>>   # link rule for the .so file, .lds has to be first
>>   $(obj)/vdso.so.dbg: $(obj)/vdso.lds $(obj-vdso) FORCE
>>   	$(call if_changed,vdsold)
>> -LDFLAGS_vdso.so.dbg = -shared -S -soname=linux-vdso.so.1 \
>> +LDFLAGS_vdso.so.dbg = -shared -soname=linux-vdso.so.1 \
>>   	--build-id=sha1 --hash-style=both --eh-frame-hdr
>>   
>>   # strip rule for the .so file
>> -- 
>> 2.34.1
>>
>