[v1] mailbox: mtk-cmdq: add missing MODULE_DESCRIPTION() macro

[PATCH] mailbox: mtk-cmdq: add missing MODULE_DESCRIPTION() macro

Posted by Jeff Johnson 1 year, 8 months ago

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mailbox/mtk-cmdq-mailbox.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/mailbox/mtk-cmdq-mailbox.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index 4aa394e91109..8247584bcbeb 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -790,4 +790,5 @@ static void __exit cmdq_drv_exit(void)
 subsys_initcall(cmdq_drv_init);
 module_exit(cmdq_drv_exit);
 
+MODULE_DESCRIPTION("Mediatek Command Queue(CMDQ) driver");
 MODULE_LICENSE("GPL v2");

---
base-commit: 19ca0d8a433ff37018f9429f7e7739e9f3d3d2b4
change-id: 20240608-md-drivers-mailbox-3cd31fdfc4b6

Re: [PATCH] mailbox: mtk-cmdq: add missing MODULE_DESCRIPTION() macro

Posted by AngeloGioacchino Del Regno 1 year, 7 months ago

Il 08/06/24 18:31, Jeff Johnson ha scritto:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mailbox/mtk-cmdq-mailbox.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>   drivers/mailbox/mtk-cmdq-mailbox.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 4aa394e91109..8247584bcbeb 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -790,4 +790,5 @@ static void __exit cmdq_drv_exit(void)
>   subsys_initcall(cmdq_drv_init);
>   module_exit(cmdq_drv_exit);
>   
> +MODULE_DESCRIPTION("Mediatek Command Queue(CMDQ) driver");

MODULE_DESCRIPTION("MediaTek Command Queue (CMDQ) Mailbox driver");

After which,

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH] mailbox: mtk-cmdq: add missing MODULE_DESCRIPTION() macro

Posted by Jeff Johnson 1 year, 7 months ago

On 6/24/2024 4:34 AM, AngeloGioacchino Del Regno wrote:
> Il 08/06/24 18:31, Jeff Johnson ha scritto:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mailbox/mtk-cmdq-mailbox.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>>   drivers/mailbox/mtk-cmdq-mailbox.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
>> index 4aa394e91109..8247584bcbeb 100644
>> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
>> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
>> @@ -790,4 +790,5 @@ static void __exit cmdq_drv_exit(void)
>>   subsys_initcall(cmdq_drv_init);
>>   module_exit(cmdq_drv_exit);
>>   
>> +MODULE_DESCRIPTION("Mediatek Command Queue(CMDQ) driver");
> 
> MODULE_DESCRIPTION("MediaTek Command Queue (CMDQ) Mailbox driver");
> 
> After which,
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

ack, v2 coming