[v5] Add support for QoS configuration

[PATCH v5 0/4] Add support for QoS configuration

Posted by Odelu Kukatla 1 year, 6 months ago

This series adds QoS support for QNOC type device which can be found on
SC7280 platform. It adds support for programming priority,
priority forward disable and urgency forwarding. This helps in
priortizing the traffic originating from different interconnect masters
at NOC (Network On Chip).

Changes in v5:
 - Replaced platform_get_resource() and devm_ioremap_resource() with
   devm_platform_ioremap_resource() API.
 - Initialized the qosbox pointer in ICC node using compound literal.
 - Added conditional check for clock property in dt-bindings to the 
   providers which need clocks.

Odelu Kukatla (4):
  interconnect: qcom: icc-rpmh: Add QoS configuration support
  interconnect: qcom: sc7280: enable QoS configuration
  dt-bindings: interconnect: add clock property to enable QOS on SC7280
  arm64: dts: qcom: sc7280: Add clocks for QOS configuration

 .../interconnect/qcom,sc7280-rpmh.yaml        |  53 ++++
 arch/arm64/boot/dts/qcom/sc7280.dtsi          |   3 +
 drivers/interconnect/qcom/icc-rpmh.c          |  93 ++++++
 drivers/interconnect/qcom/icc-rpmh.h          |  35 +++
 drivers/interconnect/qcom/sc7280.c            | 274 ++++++++++++++++++
 5 files changed, 458 insertions(+)

-- 
2.17.1

Re: [PATCH v5 0/4] Add support for QoS configuration

Posted by Dmitry Baryshkov 1 year, 6 months ago

On Fri, Jun 07, 2024 at 11:09:23PM +0530, Odelu Kukatla wrote:
> This series adds QoS support for QNOC type device which can be found on
> SC7280 platform. It adds support for programming priority,
> priority forward disable and urgency forwarding. This helps in
> priortizing the traffic originating from different interconnect masters
> at NOC (Network On Chip).
> 
> Changes in v5:
>  - Replaced platform_get_resource() and devm_ioremap_resource() with
>    devm_platform_ioremap_resource() API.
>  - Initialized the qosbox pointer in ICC node using compound literal.
>  - Added conditional check for clock property in dt-bindings to the 
>    providers which need clocks.

Please don't trim changelog from the previous revisions.

> 
> Odelu Kukatla (4):
>   interconnect: qcom: icc-rpmh: Add QoS configuration support
>   interconnect: qcom: sc7280: enable QoS configuration
>   dt-bindings: interconnect: add clock property to enable QOS on SC7280
>   arm64: dts: qcom: sc7280: Add clocks for QOS configuration
> 
>  .../interconnect/qcom,sc7280-rpmh.yaml        |  53 ++++
>  arch/arm64/boot/dts/qcom/sc7280.dtsi          |   3 +
>  drivers/interconnect/qcom/icc-rpmh.c          |  93 ++++++
>  drivers/interconnect/qcom/icc-rpmh.h          |  35 +++
>  drivers/interconnect/qcom/sc7280.c            | 274 ++++++++++++++++++
>  5 files changed, 458 insertions(+)
> 
> -- 
> 2.17.1
> 

-- 
With best wishes
Dmitry

Re: (subset) [PATCH v5 0/4] Add support for QoS configuration

Posted by Bjorn Andersson 1 year, 5 months ago

On Fri, 07 Jun 2024 23:09:23 +0530, Odelu Kukatla wrote:
> This series adds QoS support for QNOC type device which can be found on
> SC7280 platform. It adds support for programming priority,
> priority forward disable and urgency forwarding. This helps in
> priortizing the traffic originating from different interconnect masters
> at NOC (Network On Chip).
> 
> Changes in v5:
>  - Replaced platform_get_resource() and devm_ioremap_resource() with
>    devm_platform_ioremap_resource() API.
>  - Initialized the qosbox pointer in ICC node using compound literal.
>  - Added conditional check for clock property in dt-bindings to the
>    providers which need clocks.
> 
> [...]

Applied, thanks!

[4/4] arm64: dts: qcom: sc7280: Add clocks for QOS configuration
      commit: 2b5004956affaa6dd1d23d431876ad533f10418b

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>