[v1] mux: adgs1408: simplify with spi_get_device_match_data()

[PATCH] mux: adgs1408: simplify with spi_get_device_match_data()

Posted by Krzysztof Kozlowski 1 year, 8 months ago

Use spi_get_device_match_data() helper to simplify a bit the driver.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/mux/adgs1408.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c
index 22ed051eb1a4..5386cfedcb06 100644
--- a/drivers/mux/adgs1408.c
+++ b/drivers/mux/adgs1408.c
@@ -59,9 +59,7 @@ static int adgs1408_probe(struct spi_device *spi)
 	s32 idle_state;
 	int ret;
 
-	chip_id = (enum adgs1408_chip_id)device_get_match_data(dev);
-	if (!chip_id)
-		chip_id = spi_get_device_id(spi)->driver_data;
+	chip_id = (enum adgs1408_chip_id)spi_get_device_match_data(spi);
 
 	mux_chip = devm_mux_chip_alloc(dev, 1, 0);
 	if (IS_ERR(mux_chip))
-- 
2.43.0

Re: [PATCH] mux: adgs1408: simplify with spi_get_device_match_data()

Posted by Krzysztof Kozlowski 9 months, 2 weeks ago

On Thu, 06 Jun 2024 16:24:43 +0200, Krzysztof Kozlowski wrote:
> Use spi_get_device_match_data() helper to simplify a bit the driver.
> 
> 

Applied, thanks!

[1/1] mux: adgs1408: simplify with spi_get_device_match_data()
      https://git.kernel.org/krzk/linux/c/702a09507d808a8cc844ac35a8cf00b4d652dab0

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH] mux: adgs1408: simplify with spi_get_device_match_data()

Posted by Krzysztof Kozlowski 1 year, 7 months ago

On 06/06/2024 16:24, Krzysztof Kozlowski wrote:
> Use spi_get_device_match_data() helper to simplify a bit the driver.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Peter,

Any comments from your side? Can you pick it up?

Best regards,
Krzysztof