[v1] ASoC: ti: omap-hdmi: Fix too long driver name

[PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

Posted by Primoz Fiser 1 year, 8 months ago

Set driver name to DRV_NAME. This simplifies the code and gets rid of
the following error messages:

  ASoC: driver name too long 'HDMI 58040000.encoder' -> 'HDMI_58040000_e'

Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
 sound/soc/ti/omap-hdmi.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c
index 639bc83f4263..3f35eedeea41 100644
--- a/sound/soc/ti/omap-hdmi.c
+++ b/sound/soc/ti/omap-hdmi.c
@@ -354,11 +354,7 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
 	if (!card)
 		return -ENOMEM;
 
-	card->name = devm_kasprintf(dev, GFP_KERNEL,
-				    "HDMI %s", dev_name(ad->dssdev));
-	if (!card->name)
-		return -ENOMEM;
-
+	card->name = DRV_NAME;
 	card->owner = THIS_MODULE;
 	card->dai_link =
 		devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL);
-- 
2.25.1

Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

Posted by Péter Ujfalusi 1 year, 8 months ago


On 6/6/24 10:06 AM, Primoz Fiser wrote:
> Set driver name to DRV_NAME. This simplifies the code and gets rid of
> the following error messages:
> 
>   ASoC: driver name too long 'HDMI 58040000.encoder' -> 'HDMI_58040000_e'
> 
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> ---
>  sound/soc/ti/omap-hdmi.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c
> index 639bc83f4263..3f35eedeea41 100644
> --- a/sound/soc/ti/omap-hdmi.c
> +++ b/sound/soc/ti/omap-hdmi.c
> @@ -354,11 +354,7 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
>  	if (!card)
>  		return -ENOMEM;
>  
> -	card->name = devm_kasprintf(dev, GFP_KERNEL,
> -				    "HDMI %s", dev_name(ad->dssdev));
> -	if (!card->name)
> -		return -ENOMEM;
> -
> +	card->name = DRV_NAME;

I think it would be better to name is simply "HDMI" instead

>  	card->owner = THIS_MODULE;
>  	card->dai_link =
>  		devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL);

-- 
Péter

Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

Posted by Mark Brown 1 year, 8 months ago

On Thu, Jun 06, 2024 at 09:00:47PM +0300, Péter Ujfalusi wrote:
> On 6/6/24 10:06 AM, Primoz Fiser wrote:

> > -	card->name = devm_kasprintf(dev, GFP_KERNEL,
> > -				    "HDMI %s", dev_name(ad->dssdev));
> > -	if (!card->name)
> > -		return -ENOMEM;
> > -
> > +	card->name = DRV_NAME;

> I think it would be better to name is simply "HDMI" instead

That does seem a bit more user friendly.

Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

Posted by Primoz Fiser 1 year, 8 months ago

Hi,

On 6. 06. 24 20:01, Mark Brown wrote:
> On Thu, Jun 06, 2024 at 09:00:47PM +0300, Péter Ujfalusi wrote:
>> On 6/6/24 10:06 AM, Primoz Fiser wrote:
> 
>>> -	card->name = devm_kasprintf(dev, GFP_KERNEL,
>>> -				    "HDMI %s", dev_name(ad->dssdev));
>>> -	if (!card->name)
>>> -		return -ENOMEM;
>>> -
>>> +	card->name = DRV_NAME;
> 
>> I think it would be better to name is simply "HDMI" instead
> 
> That does seem a bit more user friendly.

So card->name = "HDMI" for v2?

Thanks,
BR,
Primoz

-- 
Primoz Fiser                    | phone: +386-41-390-545
<tel:+386-41-390-545> |
---------------------------------------------------------|
Norik systems d.o.o.            | https://www.norik.com
<https://www.norik.com>  |
Your embedded software partner  | email: info@norik.com
<mailto:info@norik.com> |
Slovenia, EU                    | phone: +386-41-540-545
<tel:+386-41-540-545> |

Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

Posted by Mark Brown 1 year, 8 months ago

On Fri, Jun 07, 2024 at 08:14:40AM +0200, Primoz Fiser wrote:

> So card->name = "HDMI" for v2?

Yes, please.