During kbuild, with W=1, modpost will warn when a module doesn't have
a MODULE_DESCRIPTION(). The encrypted-keys module does not have a
MODULE_DESCRIPTION().  But currently, even with an allmodconfig
configuration, this module is built-in, and as a result, kbuild does
not currently warn about the missing MODULE_DESCRIPTION().

However, just in case it is built as a module in the future, add the
missing MODULE_DESCRIPTION() macro invocation.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 security/keys/encrypted-keys/encrypted.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/keys/encrypted-keys/encrypted.c b/security/keys/encrypted-keys/encrypted.c
index 8af2136069d2..831cb84fd75a 100644
--- a/security/keys/encrypted-keys/encrypted.c
+++ b/security/keys/encrypted-keys/encrypted.c
@@ -1040,4 +1040,5 @@ static void __exit cleanup_encrypted(void)
 late_initcall(init_encrypted);
 module_exit(cleanup_encrypted);
 
+MODULE_DESCRIPTION("Encrypted key type");
 MODULE_LICENSE("GPL");

-- 
2.42.0

On Fri Jun 7, 2024 at 4:47 AM EEST, Jeff Johnson wrote:
> During kbuild, with W=1, modpost will warn when a module doesn't have
> a MODULE_DESCRIPTION(). The encrypted-keys module does not have a
> MODULE_DESCRIPTION().  But currently, even with an allmodconfig
> configuration, this module is built-in, and as a result, kbuild does
> not currently warn about the missing MODULE_DESCRIPTION().
>
> However, just in case it is built as a module in the future, add the
> missing MODULE_DESCRIPTION() macro invocation.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  security/keys/encrypted-keys/encrypted.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/security/keys/encrypted-keys/encrypted.c b/security/keys/encrypted-keys/encrypted.c
> index 8af2136069d2..831cb84fd75a 100644
> --- a/security/keys/encrypted-keys/encrypted.c
> +++ b/security/keys/encrypted-keys/encrypted.c
> @@ -1040,4 +1040,5 @@ static void __exit cleanup_encrypted(void)
>  late_initcall(init_encrypted);
>  module_exit(cleanup_encrypted);
>  
> +MODULE_DESCRIPTION("Encrypted key type");
>  MODULE_LICENSE("GPL");

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko