1. Patchew
  2. linux
  3. View series

[PATCH] HID: add missing MODULE_DESCRIPTION() macros

Jeff Johnson posted 1 patch 1 year, 8 months ago 
drivers/hid/hid-holtek-mouse.c | 1 +
drivers/hid/hid-ite.c          | 1 +
drivers/hid/hid-kensington.c   | 1 +
drivers/hid/hid-keytouch.c     | 1 +
drivers/hid/hid-kye.c          | 1 +
drivers/hid/hid-lcpower.c      | 1 +
drivers/hid/hid-lenovo.c       | 1 +
drivers/hid/hid-winwing.c      | 1 +
8 files changed, 8 insertions(+)
[PATCH] HID: add missing MODULE_DESCRIPTION() macros
Posted by Jeff Johnson 1 year, 8 months ago 
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-holtek-mouse.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ite.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kensington.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-keytouch.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kye.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lcpower.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lenovo.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-winwing.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/hid/hid-holtek-mouse.c | 1 +
 drivers/hid/hid-ite.c          | 1 +
 drivers/hid/hid-kensington.c   | 1 +
 drivers/hid/hid-keytouch.c     | 1 +
 drivers/hid/hid-kye.c          | 1 +
 drivers/hid/hid-lcpower.c      | 1 +
 drivers/hid/hid-lenovo.c       | 1 +
 drivers/hid/hid-winwing.c      | 1 +
 8 files changed, 8 insertions(+)

diff --git a/drivers/hid/hid-holtek-mouse.c b/drivers/hid/hid-holtek-mouse.c
index 7c907939bfae..343730c28e2d 100644
--- a/drivers/hid/hid-holtek-mouse.c
+++ b/drivers/hid/hid-holtek-mouse.c
@@ -110,4 +110,5 @@ static struct hid_driver holtek_mouse_driver = {
 };
 
 module_hid_driver(holtek_mouse_driver);
+MODULE_DESCRIPTION("HID driver for Holtek gaming mice");
 MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-ite.c b/drivers/hid/hid-ite.c
index 75ebfcf31889..6a7281bc27c9 100644
--- a/drivers/hid/hid-ite.c
+++ b/drivers/hid/hid-ite.c
@@ -141,4 +141,5 @@ static struct hid_driver ite_driver = {
 module_hid_driver(ite_driver);
 
 MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
+MODULE_DESCRIPTION("HID driver for some ITE \"special\" devices");
 MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-kensington.c b/drivers/hid/hid-kensington.c
index b31f7f431a3f..99e79b42047c 100644
--- a/drivers/hid/hid-kensington.c
+++ b/drivers/hid/hid-kensington.c
@@ -46,4 +46,5 @@ static struct hid_driver ks_driver = {
 };
 module_hid_driver(ks_driver);
 
+MODULE_DESCRIPTION("HID driver for Kensigton Slimblade Trackball");
 MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-keytouch.c b/drivers/hid/hid-keytouch.c
index 73bf8642dfe3..a972943baaea 100644
--- a/drivers/hid/hid-keytouch.c
+++ b/drivers/hid/hid-keytouch.c
@@ -48,5 +48,6 @@ static struct hid_driver keytouch_driver = {
 };
 module_hid_driver(keytouch_driver);
 
+MODULE_DESCRIPTION("HID driver for Keytouch devices not fully compliant with HID standard");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Jiri Kosina");
diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c
index 70ceb9437332..ca2ba3da2458 100644
--- a/drivers/hid/hid-kye.c
+++ b/drivers/hid/hid-kye.c
@@ -671,4 +671,5 @@ static struct hid_driver kye_driver = {
 };
 module_hid_driver(kye_driver);
 
+MODULE_DESCRIPTION("HID driver for Kye/Genius devices not fully compliant with HID standard");
 MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-lcpower.c b/drivers/hid/hid-lcpower.c
index 8acd3ee5ada5..58953d11ded7 100644
--- a/drivers/hid/hid-lcpower.c
+++ b/drivers/hid/hid-lcpower.c
@@ -53,4 +53,5 @@ static struct hid_driver ts_driver = {
 };
 module_hid_driver(ts_driver);
 
+MODULE_DESCRIPTION("HID driver for LC Power Model RC1000MCE");
 MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c
index e6b2ae68b8fb..e5e72aa5260a 100644
--- a/drivers/hid/hid-lenovo.c
+++ b/drivers/hid/hid-lenovo.c
@@ -1442,4 +1442,5 @@ static struct hid_driver lenovo_driver = {
 };
 module_hid_driver(lenovo_driver);
 
+MODULE_DESCRIPTION("HID driver for IBM/Lenovo");
 MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-winwing.c b/drivers/hid/hid-winwing.c
index 0e224d1a6466..10a5d87ccb96 100644
--- a/drivers/hid/hid-winwing.c
+++ b/drivers/hid/hid-winwing.c
@@ -223,4 +223,5 @@ static struct hid_driver winwing_driver = {
 };
 module_hid_driver(winwing_driver);
 
+MODULE_DESCRIPTION("HID driver for WinWing Orion 2 throttle");
 MODULE_LICENSE("GPL");

---
base-commit: 19ca0d8a433ff37018f9429f7e7739e9f3d3d2b4
change-id: 20240606-md-drivers-hid-42e9f9c85cd9
Re: [PATCH] HID: add missing MODULE_DESCRIPTION() macros
Posted by Jeff Johnson 1 year, 8 months ago 
On 6/6/2024 10:09 PM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-holtek-mouse.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ite.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kensington.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-keytouch.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kye.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lcpower.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lenovo.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-winwing.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/hid/hid-holtek-mouse.c | 1 +
>  drivers/hid/hid-ite.c          | 1 +
>  drivers/hid/hid-kensington.c   | 1 +
>  drivers/hid/hid-keytouch.c     | 1 +
>  drivers/hid/hid-kye.c          | 1 +
>  drivers/hid/hid-lcpower.c      | 1 +
>  drivers/hid/hid-lenovo.c       | 1 +
>  drivers/hid/hid-winwing.c      | 1 +
>  8 files changed, 8 insertions(+)

please ignore this patch -- this is a duplicate
Re: [PATCH] HID: add missing MODULE_DESCRIPTION() macros
Posted by Jeff Johnson 1 year, 8 months ago 
On 6/6/2024 10:12 PM, Jeff Johnson wrote:
> On 6/6/2024 10:09 PM, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-holtek-mouse.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ite.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kensington.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-keytouch.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kye.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lcpower.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lenovo.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-winwing.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>>  drivers/hid/hid-holtek-mouse.c | 1 +
>>  drivers/hid/hid-ite.c          | 1 +
>>  drivers/hid/hid-kensington.c   | 1 +
>>  drivers/hid/hid-keytouch.c     | 1 +
>>  drivers/hid/hid-kye.c          | 1 +
>>  drivers/hid/hid-lcpower.c      | 1 +
>>  drivers/hid/hid-lenovo.c       | 1 +
>>  drivers/hid/hid-winwing.c      | 1 +
>>  8 files changed, 8 insertions(+)
> 
> please ignore this patch -- this is a duplicate
> 
Well, according to my spreadsheet these were duplicates since they were
supposed to have been in:
https://lore.kernel.org/all/20240604-md-hid-misc-v1-1-4f9560796f3c@quicinc.com/

But I somehow forgot to add them to that patch, so this is a valid patch after
all.  Please pick it up.

/jeff

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.