[PATCH v2] dmaengine: add missing MODULE_DESCRIPTION() macros

Jeff Johnson posted 1 patch 1 year, 8 months ago
drivers/dma/dmatest.c     | 1 +
drivers/dma/idxd/init.c   | 1 +
drivers/dma/ioat/init.c   | 1 +
drivers/dma/ti/omap-dma.c | 1 +
4 files changed, 4 insertions(+)
[PATCH v2] dmaengine: add missing MODULE_DESCRIPTION() macros
Posted by Jeff Johnson 1 year, 8 months ago
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/idxd/idxd.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/ti/omap-dma.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/dmatest.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/ioat/ioatdma.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Acked-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
Changes in v2:
- Updated drivers/dma/idxd/init.c with description from Dave Jiang
- Updated drivers/dma/ti/omap-dma.c with description from Péter Ujfalusi
- Link to v1: https://lore.kernel.org/r/20240605-md-drivers-dma-v1-1-bcbcfd9ce706@quicinc.com
---
 drivers/dma/dmatest.c     | 1 +
 drivers/dma/idxd/init.c   | 1 +
 drivers/dma/ioat/init.c   | 1 +
 drivers/dma/ti/omap-dma.c | 1 +
 4 files changed, 4 insertions(+)

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index a4f608837849..1f201a542b37 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -1372,4 +1372,5 @@ static void __exit dmatest_exit(void)
 module_exit(dmatest_exit);
 
 MODULE_AUTHOR("Haavard Skinnemoen (Atmel)");
+MODULE_DESCRIPTION("DMA Engine test module");
 MODULE_LICENSE("GPL v2");
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
index a7295943fa22..e37faa709d9b 100644
--- a/drivers/dma/idxd/init.c
+++ b/drivers/dma/idxd/init.c
@@ -22,6 +22,7 @@
 #include "perfmon.h"
 
 MODULE_VERSION(IDXD_DRIVER_VERSION);
+MODULE_DESCRIPTION("Intel Data Streaming Accelerator and In-Memory Analytics Accelerator common driver");
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Intel Corporation");
 MODULE_IMPORT_NS(IDXD);
diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
index 9c364e92cb82..d84d95321f43 100644
--- a/drivers/dma/ioat/init.c
+++ b/drivers/dma/ioat/init.c
@@ -23,6 +23,7 @@
 #include "../dmaengine.h"
 
 MODULE_VERSION(IOAT_DMA_VERSION);
+MODULE_DESCRIPTION("Intel I/OAT DMA Linux driver");
 MODULE_LICENSE("Dual BSD/GPL");
 MODULE_AUTHOR("Intel Corporation");
 
diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
index b9e0e22383b7..7e6c04afbe89 100644
--- a/drivers/dma/ti/omap-dma.c
+++ b/drivers/dma/ti/omap-dma.c
@@ -1950,4 +1950,5 @@ static void __exit omap_dma_exit(void)
 module_exit(omap_dma_exit);
 
 MODULE_AUTHOR("Russell King");
+MODULE_DESCRIPTION("Texas Instruments sDMA DMAengine support");
 MODULE_LICENSE("GPL");

---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240605-md-drivers-dma-2105b7b6f243

Re: [PATCH v2] dmaengine: add missing MODULE_DESCRIPTION() macros
Posted by Vinod Koul 1 year, 8 months ago
On Thu, 06 Jun 2024 13:00:01 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/idxd/idxd.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/ti/omap-dma.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/dmatest.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/ioat/ioatdma.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> [...]

Applied, thanks!

[1/1] dmaengine: add missing MODULE_DESCRIPTION() macros
      commit: 6e2fb806e08d46cbeb96c1000ef531a92d3b2e9a

Best regards,
-- 
Vinod Koul <vkoul@kernel.org>
Re: [PATCH v2] dmaengine: add missing MODULE_DESCRIPTION() macros
Posted by Jeff Johnson 1 year, 6 months ago
On 6/7/2024 10:47 AM, Vinod Koul wrote:
> 
> On Thu, 06 Jun 2024 13:00:01 -0700, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/idxd/idxd.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/ti/omap-dma.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/dmatest.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/ioat/ioatdma.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] dmaengine: add missing MODULE_DESCRIPTION() macros
>       commit: 6e2fb806e08d46cbeb96c1000ef531a92d3b2e9a
> 
> Best regards,

Hi,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.

Thanks!
/jeff