arch/arm/boot/dts/rockchip/rk3128.dtsi | 35 ++++++++++++++++++++++++++ drivers/clk/rockchip/clk-rk3128.c | 21 +++++++++++++--- include/dt-bindings/clock/rk3128-cru.h | 2 +- 3 files changed, 53 insertions(+), 5 deletions(-)
This series adds support for the Serial Flash Controller (SFC) found in RK3128 SoCs. As without using some "id holes" we would run out clock ids in the binding and would have to touch the ABI, I added patches which removes the CLK_NR_CLKS macro and uses the recently introduced rockchip_clk_find_max_clk_id helper instead to find the highest clock id. changes since v1: - added patches to remove CLK_NR_CLKS (Connor) Link to v1: https://lore.kernel.org/all/20240605172154.193047-1-knaerzche@gmail.com/ Alex Bee (5): clk: rockchip: rk3128: Drop CLK_NR_CLKS usage dt-bindings: clock: rk3128: Drop CLK_NR_CLKS dt-bindings: clock: rk3128: Add HCLK_SFC clk: rockchip: Add HCLK_SFC for RK3128 ARM: dts: rockchip: Add SFC for RK3128 arch/arm/boot/dts/rockchip/rk3128.dtsi | 35 ++++++++++++++++++++++++++ drivers/clk/rockchip/clk-rk3128.c | 21 +++++++++++++--- include/dt-bindings/clock/rk3128-cru.h | 2 +- 3 files changed, 53 insertions(+), 5 deletions(-) base-commit: 234cb065ad82915ff8d06ce01e01c3e640b674d2 -- 2.45.2
On 05/06/2024 22:52, Alex Bee wrote: > This series adds support for the Serial Flash Controller (SFC) found in > RK3128 SoCs. > > As without using some "id holes" we would run out clock ids in the binding > and would have to touch the ABI, I added patches which removes the > CLK_NR_CLKS macro and uses the recently introduced > rockchip_clk_find_max_clk_id helper instead to find the highest clock id. > > changes since v1: > - added patches to remove CLK_NR_CLKS (Connor) > Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. You sent now v2 immediately after. Confused. Best regards, Krzysztof
Am Donnerstag, 6. Juni 2024, 08:41:19 CEST schrieb Krzysztof Kozlowski: > On 05/06/2024 22:52, Alex Bee wrote: > > This series adds support for the Serial Flash Controller (SFC) found in > > RK3128 SoCs. > > > > As without using some "id holes" we would run out clock ids in the binding > > and would have to touch the ABI, I added patches which removes the > > CLK_NR_CLKS macro and uses the recently introduced > > rockchip_clk_find_max_clk_id helper instead to find the highest clock id. > > > > changes since v1: > > - added patches to remove CLK_NR_CLKS (Connor) > > > > Do not attach (thread) your patchsets to some other threads (unrelated > or older versions). This buries them deep in the mailbox and might > interfere with applying entire sets. > > You sent now v2 immediately after. Confused. it looks like Alex had some mail trouble yesterday. The thread you Acked patches in actually is v2, just missing the label. - original v1: https://lore.kernel.org/linux-rockchip/20240605172154.193047-1-knaerzche@gmail.com - "unlabeled" v2: https://lore.kernel.org/linux-rockchip/20240605205209.232005-1-knaerzche@gmail.com/ - this as v2, but as reply to the previous - real v2: https://lore.kernel.org/linux-rockchip/20240605210049.232284-1-knaerzche@gmail.com/ The last 3 are identical, just the sending process was somehow fumbled.
Hi Heiko, Hi Krzysztof, Am 06.06.24 um 09:37 schrieb Heiko Stübner: > Am Donnerstag, 6. Juni 2024, 08:41:19 CEST schrieb Krzysztof Kozlowski: >> On 05/06/2024 22:52, Alex Bee wrote: >>> This series adds support for the Serial Flash Controller (SFC) found in >>> RK3128 SoCs. >>> >>> As without using some "id holes" we would run out clock ids in the binding >>> and would have to touch the ABI, I added patches which removes the >>> CLK_NR_CLKS macro and uses the recently introduced >>> rockchip_clk_find_max_clk_id helper instead to find the highest clock id. >>> >>> changes since v1: >>> - added patches to remove CLK_NR_CLKS (Connor) >>> >> Do not attach (thread) your patchsets to some other threads (unrelated >> or older versions). This buries them deep in the mailbox and might >> interfere with applying entire sets. >> >> You sent now v2 immediately after. Confused. > it looks like Alex had some mail trouble yesterday. > > The thread you Acked patches in actually is v2, just missing the label. > > - original v1: https://lore.kernel.org/linux-rockchip/20240605172154.193047-1-knaerzche@gmail.com > > - "unlabeled" v2: https://lore.kernel.org/linux-rockchip/20240605205209.232005-1-knaerzche@gmail.com/ > - this as v2, but as reply to the previous > - real v2: https://lore.kernel.org/linux-rockchip/20240605210049.232284-1-knaerzche@gmail.com/ > > The last 3 are identical, just the sending process was somehow fumbled. Yes, that's why I replied to the first message in the messed-up thread explaining it a bit: https://lore.kernel.org/all/9da22443-b5c3-4fbc-8cb0-d6bebab55da4@gmail.com/ Anyway: To make it a bit less confusing, I'll send v3 with Krzysztof's acks included. Alex > >
© 2016 - 2026 Red Hat, Inc.