Fix doorbell emulation for v2 API on PPC

[PATCH v2 0/2] Fix doorbell emulation for v2 API on PPC

Posted by Gautam Menghani 1 year, 8 months ago

Doorbell emulation for KVM on PAPR guests is broken as support for DPDES
was not added in initial patch series [1].
Add DPDES support and doorbell handling support for V2 API. 

[1] lore.kernel.org/linuxppc-dev/20230914030600.16993-1-jniethe5@gmail.com

Changes in v2:
1. Split DPDES support into its own patch

Gautam Menghani (2):
  arch/powerpc/kvm: Add DPDES support in helper library for Guest state
    buffer
  arch/powerpc/kvm: Fix doorbell emulation for v2 API

 Documentation/arch/powerpc/kvm-nested.rst     | 4 +++-
 arch/powerpc/include/asm/guest-state-buffer.h | 3 ++-
 arch/powerpc/include/asm/kvm_book3s.h         | 1 +
 arch/powerpc/kvm/book3s_hv.c                  | 5 +++++
 arch/powerpc/kvm/book3s_hv_nestedv2.c         | 7 +++++++
 arch/powerpc/kvm/test-guest-state-buffer.c    | 2 +-
 6 files changed, 19 insertions(+), 3 deletions(-)

-- 
2.45.1

Re: [PATCH v2 0/2] Fix doorbell emulation for v2 API on PPC

Posted by Michael Ellerman 1 year, 7 months ago

On Wed, 05 Jun 2024 17:09:08 +0530, Gautam Menghani wrote:
> Doorbell emulation for KVM on PAPR guests is broken as support for DPDES
> was not added in initial patch series [1].
> Add DPDES support and doorbell handling support for V2 API.
> 
> [1] lore.kernel.org/linuxppc-dev/20230914030600.16993-1-jniethe5@gmail.com
> 
> Changes in v2:
> 1. Split DPDES support into its own patch
> 
> [...]

Applied to powerpc/topic/ppc-kvm.

[1/2] arch/powerpc/kvm: Add DPDES support in helper library for Guest state buffer
      https://git.kernel.org/powerpc/c/55dfb8bed6fe8bda390cc71cca878d11a9407099
[2/2] arch/powerpc/kvm: Fix doorbell emulation for v2 API
      https://git.kernel.org/powerpc/c/54ec2bd9e0173b75daf84675d07c56584f96564b

cheers

Re: [PATCH v2 0/2] Fix doorbell emulation for v2 API on PPC

Posted by Gautam Menghani 1 year, 8 months ago

On Wed, Jun 05, 2024 at 05:09:08PM GMT, Gautam Menghani wrote:
> Doorbell emulation for KVM on PAPR guests is broken as support for DPDES
> was not added in initial patch series [1].
> Add DPDES support and doorbell handling support for V2 API. 
> 
> [1] lore.kernel.org/linuxppc-dev/20230914030600.16993-1-jniethe5@gmail.com
> 
> Changes in v2:
> 1. Split DPDES support into its own patch
> 
> Gautam Menghani (2):
>   arch/powerpc/kvm: Add DPDES support in helper library for Guest state
>     buffer
>   arch/powerpc/kvm: Fix doorbell emulation for v2 API
> 
>  Documentation/arch/powerpc/kvm-nested.rst     | 4 +++-
>  arch/powerpc/include/asm/guest-state-buffer.h | 3 ++-
>  arch/powerpc/include/asm/kvm_book3s.h         | 1 +
>  arch/powerpc/kvm/book3s_hv.c                  | 5 +++++
>  arch/powerpc/kvm/book3s_hv_nestedv2.c         | 7 +++++++
>  arch/powerpc/kvm/test-guest-state-buffer.c    | 2 +-
>  6 files changed, 19 insertions(+), 3 deletions(-)
> 
> -- 
> 2.45.1
> 


Hi Michael,

This patch series is to be backported for all kernels >= 6.7. So the tag
should be 
Cc: stable@vger.kernel.org # v6.7+

and not
Cc: stable@vger.kernel.org # v6.7

Should I send a new version of this series or can you please make this 
change when pulling in your tree?

Thanks,
Gautam

Re: [PATCH v2 0/2] Fix doorbell emulation for v2 API on PPC

Posted by Michael Ellerman 1 year, 8 months ago

Gautam Menghani <gautam@linux.ibm.com> writes:
> On Wed, Jun 05, 2024 at 05:09:08PM GMT, Gautam Menghani wrote:
>> Doorbell emulation for KVM on PAPR guests is broken as support for DPDES
>> was not added in initial patch series [1].
>> Add DPDES support and doorbell handling support for V2 API. 
>> 
>> [1] lore.kernel.org/linuxppc-dev/20230914030600.16993-1-jniethe5@gmail.com
>> 
>> Changes in v2:
>> 1. Split DPDES support into its own patch
>> 
>> Gautam Menghani (2):
>>   arch/powerpc/kvm: Add DPDES support in helper library for Guest state
>>     buffer
>>   arch/powerpc/kvm: Fix doorbell emulation for v2 API
>> 
>>  Documentation/arch/powerpc/kvm-nested.rst     | 4 +++-
>>  arch/powerpc/include/asm/guest-state-buffer.h | 3 ++-
>>  arch/powerpc/include/asm/kvm_book3s.h         | 1 +
>>  arch/powerpc/kvm/book3s_hv.c                  | 5 +++++
>>  arch/powerpc/kvm/book3s_hv_nestedv2.c         | 7 +++++++
>>  arch/powerpc/kvm/test-guest-state-buffer.c    | 2 +-
>>  6 files changed, 19 insertions(+), 3 deletions(-)
>> 
>> -- 
>> 2.45.1
>> 
>
>
> Hi Michael,
>
> This patch series is to be backported for all kernels >= 6.7. So the tag
> should be 
> Cc: stable@vger.kernel.org # v6.7+
>
> and not
> Cc: stable@vger.kernel.org # v6.7
>
> Should I send a new version of this series or can you please make this 
> change when pulling in your tree?

I can make the change when applying.

cheers

Re: [PATCH v2 0/2] Fix doorbell emulation for v2 API on PPC

Posted by Nicholas Piggin 1 year, 8 months ago

On Wed Jun 5, 2024 at 9:39 PM AEST, Gautam Menghani wrote:
> Doorbell emulation for KVM on PAPR guests is broken as support for DPDES
> was not added in initial patch series [1].
> Add DPDES support and doorbell handling support for V2 API. 

Looks good, thanks. So fix for v1 doorbells is coming?

Thanks,
Nick

>
> [1] lore.kernel.org/linuxppc-dev/20230914030600.16993-1-jniethe5@gmail.com
>
> Changes in v2:
> 1. Split DPDES support into its own patch
>
> Gautam Menghani (2):
>   arch/powerpc/kvm: Add DPDES support in helper library for Guest state
>     buffer
>   arch/powerpc/kvm: Fix doorbell emulation for v2 API
>
>  Documentation/arch/powerpc/kvm-nested.rst     | 4 +++-
>  arch/powerpc/include/asm/guest-state-buffer.h | 3 ++-
>  arch/powerpc/include/asm/kvm_book3s.h         | 1 +
>  arch/powerpc/kvm/book3s_hv.c                  | 5 +++++
>  arch/powerpc/kvm/book3s_hv_nestedv2.c         | 7 +++++++
>  arch/powerpc/kvm/test-guest-state-buffer.c    | 2 +-
>  6 files changed, 19 insertions(+), 3 deletions(-)

Re: [PATCH v2 0/2] Fix doorbell emulation for v2 API on PPC

Posted by Gautam Menghani 1 year, 8 months ago

On Thu, Jun 06, 2024 at 01:00:19PM GMT, Nicholas Piggin wrote:
> On Wed Jun 5, 2024 at 9:39 PM AEST, Gautam Menghani wrote:
> > Doorbell emulation for KVM on PAPR guests is broken as support for DPDES
> > was not added in initial patch series [1].
> > Add DPDES support and doorbell handling support for V2 API. 
> 
> Looks good, thanks. So fix for v1 doorbells is coming?

Yes I've root caused the doorbell breakage in V1 API to 
commit 7c3ded5735141ff4d049747c9f76672a8b737c49. I'll send out a fix
soon.

Thanks,
Gautam