perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

[PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

Posted by linux@treblig.org 1 year, 8 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'hisi_ptt_queue' has been unused since the original
commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
HiSilicon PCIe Trace packet").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 tools/perf/util/hisi-ptt.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
index 52d0ce302ca0..37ea987017f6 100644
--- a/tools/perf/util/hisi-ptt.c
+++ b/tools/perf/util/hisi-ptt.c
@@ -35,11 +35,6 @@ struct hisi_ptt {
 	u32 pmu_type;
 };
 
-struct hisi_ptt_queue {
-	struct hisi_ptt *ptt;
-	struct auxtrace_buffer *buffer;
-};
-
 static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
 {
 	uint32_t head = *(uint32_t *)buf;
-- 
2.45.1

Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

Posted by Namhyung Kim 1 year, 8 months ago

On Sun, 02 Jun 2024 01:07:09 +0100, linux@treblig.org wrote:

Applied to perf-tools-next, thanks!

Best regards,
Namhyung

Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

Posted by Ian Rogers 1 year, 8 months ago

On Sat, Jun 1, 2024 at 5:07 PM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'hisi_ptt_queue' has been unused since the original
> commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
> HiSilicon PCIe Trace packet").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Hi/thanks David,

Reviewed-by: Ian Rogers <irogers@google.com>

Ian

> ---
>  tools/perf/util/hisi-ptt.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index 52d0ce302ca0..37ea987017f6 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
> @@ -35,11 +35,6 @@ struct hisi_ptt {
>         u32 pmu_type;
>  };
>
> -struct hisi_ptt_queue {
> -       struct hisi_ptt *ptt;
> -       struct auxtrace_buffer *buffer;
> -};
> -
>  static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
>  {
>         uint32_t head = *(uint32_t *)buf;
> --
> 2.45.1
>

Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

Posted by Jonathan Cameron 1 year, 8 months ago

On Sun,  2 Jun 2024 01:07:09 +0100
linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'hisi_ptt_queue' has been unused since the original
> commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
> HiSilicon PCIe Trace packet").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
LGTM
Minimal
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
by which I mean I searched for it and indeed found only this definition.

> ---
>  tools/perf/util/hisi-ptt.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index 52d0ce302ca0..37ea987017f6 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
> @@ -35,11 +35,6 @@ struct hisi_ptt {
>  	u32 pmu_type;
>  };
>  
> -struct hisi_ptt_queue {
> -	struct hisi_ptt *ptt;
> -	struct auxtrace_buffer *buffer;
> -};
> -
>  static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
>  {
>  	uint32_t head = *(uint32_t *)buf;