perf genelf: remove unused struct 'options'

[PATCH] perf genelf: remove unused struct 'options'

Posted by linux@treblig.org 1 year, 8 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'options' has been unused since
commit fa7f7e735495 ("perf jit: Move test functionality in to a test").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 tools/perf/util/genelf.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
index ac17a3cb59dc..c8f6bee1fa61 100644
--- a/tools/perf/util/genelf.c
+++ b/tools/perf/util/genelf.c
@@ -54,11 +54,6 @@ typedef struct {
   char         name[0]; /* Start of the name+desc data */
 } Elf_Note;
 
-struct options {
-	char *output;
-	int fd;
-};
-
 static char shd_string_table[] = {
 	0,
 	'.', 't', 'e', 'x', 't', 0,			/*  1 */
-- 
2.45.1

Re: [PATCH] perf genelf: remove unused struct 'options'

Posted by Namhyung Kim 1 year, 8 months ago

On Sun, 2 Jun 2024 01:05:05 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'options' has been unused since
> commit fa7f7e735495 ("perf jit: Move test functionality in to a test").
> 
> Remove it.
> 
> [...]

Applied to perf-tools-next, thanks!

Best regards,
-- 
Namhyung Kim <namhyung@kernel.org>

Re: [PATCH] perf genelf: remove unused struct 'options'

Posted by Ian Rogers 1 year, 8 months ago

On Sat, Jun 1, 2024 at 5:05 PM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'options' has been unused since
> commit fa7f7e735495 ("perf jit: Move test functionality in to a test").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Hi/thanks David,

Reviewed-by: Ian Rogers <irogers@google.com>

Ian

> ---
>  tools/perf/util/genelf.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
> index ac17a3cb59dc..c8f6bee1fa61 100644
> --- a/tools/perf/util/genelf.c
> +++ b/tools/perf/util/genelf.c
> @@ -54,11 +54,6 @@ typedef struct {
>    char         name[0]; /* Start of the name+desc data */
>  } Elf_Note;
>
> -struct options {
> -       char *output;
> -       int fd;
> -};
> -
>  static char shd_string_table[] = {
>         0,
>         '.', 't', 'e', 'x', 't', 0,                     /*  1 */
> --
> 2.45.1
>