ublk_drv: add missing MODULE_DESCRIPTION() macro

[PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro

Posted by Jeff Johnson 1 year, 8 months ago

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/block/ublk_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 4e159948c912..59916895ee2e 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644);
 MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)");
 
 MODULE_AUTHOR("Ming Lei <ming.lei@redhat.com>");
+MODULE_DESCRIPTION("Userspace block device");
 MODULE_LICENSE("GPL");

---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240602-md-block-ublk_drv-01507a0ba6fb

Re: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro

Posted by Jens Axboe 1 year, 7 months ago

On Sun, 02 Jun 2024 17:23:26 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> 

Applied, thanks!

[1/1] ublk_drv: add missing MODULE_DESCRIPTION() macro
      commit: c25a271c294b8f064f5628ea4fc3c6b8d47bf227

Best regards,
-- 
Jens Axboe

Re: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro

Posted by Ming Lei 1 year, 8 months ago

On Sun, Jun 02, 2024 at 05:23:26PM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/block/ublk_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 4e159948c912..59916895ee2e 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644);
>  MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)");
>  
>  MODULE_AUTHOR("Ming Lei <ming.lei@redhat.com>");
> +MODULE_DESCRIPTION("Userspace block device");
>  MODULE_LICENSE("GPL");

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks,
Ming

Re: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro

Posted by Jeff Johnson 1 year, 7 months ago

On 6/2/2024 5:53 PM, Ming Lei wrote:
> On Sun, Jun 02, 2024 at 05:23:26PM -0700, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>>  drivers/block/ublk_drv.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
>> index 4e159948c912..59916895ee2e 100644
>> --- a/drivers/block/ublk_drv.c
>> +++ b/drivers/block/ublk_drv.c
>> @@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644);
>>  MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)");
>>  
>>  MODULE_AUTHOR("Ming Lei <ming.lei@redhat.com>");
>> +MODULE_DESCRIPTION("Userspace block device");
>>  MODULE_LICENSE("GPL");
> 
> Reviewed-by: Ming Lei <ming.lei@redhat.com>

I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.