loop: add missing MODULE_DESCRIPTION() macro

[PATCH] loop: add missing MODULE_DESCRIPTION() macro

Posted by Jeff Johnson 1 year, 8 months ago

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/loop.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/block/loop.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 93780f41646b..9455c82451aa 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1830,6 +1830,7 @@ static const struct kernel_param_ops loop_hw_qdepth_param_ops = {
 device_param_cb(hw_queue_depth, &loop_hw_qdepth_param_ops, &hw_queue_depth, 0444);
 MODULE_PARM_DESC(hw_queue_depth, "Queue depth for each hardware queue. Default: " __stringify(LOOP_DEFAULT_HW_Q_DEPTH));
 
+MODULE_DESCRIPTION("Loopback device support");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_BLOCKDEV_MAJOR(LOOP_MAJOR);
 

---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240602-md-block-loop-756a95ba7841

Re: [PATCH] loop: add missing MODULE_DESCRIPTION() macro

Posted by Jens Axboe 1 year, 7 months ago

On Sun, 02 Jun 2024 17:15:09 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/loop.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> 

Applied, thanks!

[1/1] loop: add missing MODULE_DESCRIPTION() macro
      commit: 7d4425d2c9db957f0040c255ba29db61b993b4db

Best regards,
-- 
Jens Axboe

Re: [PATCH] loop: add missing MODULE_DESCRIPTION() macro

Posted by Jeff Johnson 1 year, 7 months ago

On 6/2/2024 5:15 PM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/loop.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/block/loop.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 93780f41646b..9455c82451aa 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1830,6 +1830,7 @@ static const struct kernel_param_ops loop_hw_qdepth_param_ops = {
>  device_param_cb(hw_queue_depth, &loop_hw_qdepth_param_ops, &hw_queue_depth, 0444);
>  MODULE_PARM_DESC(hw_queue_depth, "Queue depth for each hardware queue. Default: " __stringify(LOOP_DEFAULT_HW_Q_DEPTH));
>  
> +MODULE_DESCRIPTION("Loopback device support");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS_BLOCKDEV_MAJOR(LOOP_MAJOR);
>  
> 
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240602-md-block-loop-756a95ba7841

I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.