TI tla2021 is a limited single-channel variant of tla2024 which is
similar enough to be easily supportable through the same driver.

Add compatible string for tla2021 so boards may describe it in
device-tree.

Signed-off-by: Josua Mayer <josua@solid-run.com>
---
 Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
index d605999ffe28..718f633c6e04 100644
--- a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
@@ -18,6 +18,7 @@ properties:
     enum:
       - ti,ads1015
       - ti,ads1115
+      - ti,tla2021
       - ti,tla2024
 
   reg:

-- 
2.35.3

On Sun, Jun 02, 2024 at 05:49:38PM +0200, Josua Mayer wrote:
> TI tla2021 is a limited single-channel variant of tla2024 which is
> similar enough to be easily supportable through the same driver.
> 
> Add compatible string for tla2021 so boards may describe it in
> device-tree.
> 
> Signed-off-by: Josua Mayer <josua@solid-run.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
> index d605999ffe28..718f633c6e04 100644
> --- a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
> @@ -18,6 +18,7 @@ properties:
>      enum:
>        - ti,ads1015
>        - ti,ads1115
> +      - ti,tla2021
>        - ti,tla2024
>  
>    reg:
> 
> -- 
> 2.35.3
> 

On Tue, 4 Jun 2024 18:42:46 +0100
Conor Dooley <conor@kernel.org> wrote:

> On Sun, Jun 02, 2024 at 05:49:38PM +0200, Josua Mayer wrote:
> > TI tla2021 is a limited single-channel variant of tla2024 which is
> > similar enough to be easily supportable through the same driver.
> > 
> > Add compatible string for tla2021 so boards may describe it in
> > device-tree.
> > 
> > Signed-off-by: Josua Mayer <josua@solid-run.com>  
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

This binding has per channel descriptions. Perhaps for this device
it should be updated to include a restriction on number of
such sub nodes (probably via the reg value in them) ?

Mind you it's currently 8 and the ti,tla2024 only has 4.
So a possible job for another day, hopefully alongside the
driver support and the tla2022 which seems to be the 2 channel
version.

Applied.

Thanks,

Jonathan

> 
> Thanks,
> Conor.
> 
> > ---
> >  Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
> > index d605999ffe28..718f633c6e04 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
> > @@ -18,6 +18,7 @@ properties:
> >      enum:
> >        - ti,ads1015
> >        - ti,ads1115
> > +      - ti,tla2021
> >        - ti,tla2024
> >  
> >    reg:
> > 
> > -- 
> > 2.35.3
> >

On Thu, Jun 06, 2024 at 09:12:22PM +0100, Jonathan Cameron wrote:
> On Tue, 4 Jun 2024 18:42:46 +0100
> Conor Dooley <conor@kernel.org> wrote:
> 
> > On Sun, Jun 02, 2024 at 05:49:38PM +0200, Josua Mayer wrote:
> > > TI tla2021 is a limited single-channel variant of tla2024 which is
> > > similar enough to be easily supportable through the same driver.
> > > 
> > > Add compatible string for tla2021 so boards may describe it in
> > > device-tree.
> > > 
> > > Signed-off-by: Josua Mayer <josua@solid-run.com>  
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> This binding has per channel descriptions. Perhaps for this device
> it should be updated to include a restriction on number of
> such sub nodes (probably via the reg value in them) ?

Oh yeah, it probably should be, using an enum of permitted values.

> Mind you it's currently 8 and the ti,tla2024 only has 4.
> So a possible job for another day, hopefully alongside the
> driver support and the tla2022 which seems to be the 2 channel
> version.

Or a follow-up from Josua if they want, don't think it'd be too hard
to add restrictions for these two tla devices.